feat: redesign Storage section #2608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
force-pushed
the
astandrik.2446
branch
from
e842216 to
02fc2b1
Compare
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
astandrik
force-pushed
the
astandrik.2446
branch
from
d406716 to
21600f4
Compare
astandrik
force-pushed
the
astandrik.2446
branch
from
21600f4 to
7477f0e
Compare
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx
Show resolved
Hide resolved
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx
Outdated
Show resolved
Hide resolved
|
bugbot run |
There was a problem hiding this comment.
Pull Request Overview
This PR redesigns the Storage section of the tenant overview page by restructuring the UI to use tabs for different storage views and modernizing the progress visualization components.
- Reorganizes storage content into tabbed interface with separate views for Tables and Groups
- Replaces existing ProgressViewer component with a new ProgressWrapper implementation
- Adds query parameter management for storage tab state persistence
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/progress.ts | Adds shared progress formatting utilities extracted from ProgressViewer |
| src/store/reducers/tenant/types.ts | Adds TenantStorageTab type for storage tab management |
| src/store/reducers/tenant/tenant.ts | Improves type safety for metrics tab validation |
| src/store/reducers/tenant/constants.ts | Defines constants for storage tab IDs |
| src/containers/Tenant/TenantPages.tsx | Removes unused cpuTab from TenantTabsGroups |
| src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json | Adds i18n keys for new storage section titles |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/useTenantStorageQueryParams.ts | Implements query parameter management for storage tabs |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/i18n/ | Creates i18n files for ProgressWrapper component |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/constants.ts | Defines constants for progress component configuration |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TopTables.tsx | Removes hardcoded title from TopTables component |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx | Restructures storage UI with tabs and new ProgressWrapper |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.scss | Adds styling for tabbed storage interface |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx | Implements new progress visualization component |
| src/containers/Tenant/Diagnostics/TenantOverview/TenantDashboard/TenantDashboard.scss | Updates spacing to use design tokens |
| src/components/ProgressViewer/ | Refactors to use shared progress utilities |
| src/components/MemoryViewer/MemoryViewer.tsx | Updates import path for FormatProgressViewerValues type |
| src/components/InfoViewer/ | Adds small variant styling option |
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx
Outdated
Show resolved
Hide resolved
artemmufazalov
requested changes
Jul 25, 2025
Comment on lines
+1
to
+4
| { | ||
| "alert_no-data": "No data", | ||
| "context_capacity-usage": "{{value}} of {{capacity}}" | ||
| } |
There was a problem hiding this comment.
It is and src/components/ProgressViewer/i18n/en.json are duplicates
There was a problem hiding this comment.
What do you suggest?
There was a problem hiding this comment.
cluster also has this key
There was a problem hiding this comment.
key in ProgressView is unused - removed it
Comment on lines
11
to
20
| // Parse and validate storageTab with fallback to tables | ||
| const storageTab: TenantStorageTab = (() => { | ||
| if (!queryParams.storageTab) { | ||
| return TENANT_STORAGE_TABS_IDS.tables; | ||
| } | ||
| const validTabs = Object.values(TENANT_STORAGE_TABS_IDS) as string[]; | ||
| return validTabs.includes(queryParams.storageTab) | ||
| ? (queryParams.storageTab as TenantStorageTab) | ||
| : TENANT_STORAGE_TABS_IDS.tables; | ||
| })(); |
There was a problem hiding this comment.
export const tenantStorageTabSchema = z
.nativeEnum(TENANT_STORAGE_TABS_IDS)
.catch(TENANT_STORAGE_TABS_IDS.tables);
const tab = tenantStorageTabSchema.parse(queryParams.storageTab);| const clampedFillWidth = Math.min(fillWidth, MAX_PERCENTAGE); | ||
|
|
||
| const [valueText, capacityText] = React.useMemo(() => { | ||
| if (formatValues) { |
There was a problem hiding this comment.
formatValues is always defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2446
Stand
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.29 MB | Main: 85.26 MB
Diff: +0.03 MB (0.03%)
ℹ️ CI Information