Skip to content

fix: jumping content in database tabs #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2025
Merged

fix: jumping content in database tabs #2606

merged 4 commits into from
Jul 24, 2025
+29 −2

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jul 23, 2025 •
edited by github-actions bot
Loading

Closes #2605

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 350 0 2 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.21 MB | Main: 85.21 MB
Diff: +1.95 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot July 23, 2025 12:41
@astandrik
Copy link
Collaborator Author

bugbot run

Copilot

This comment was marked as outdated.

Sign in to view

@ydb-platform ydb-platform deleted a comment from Copilot AI Jul 23, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot July 23, 2025 12:51
Copilot

This comment was marked as outdated.

Sign in to view

@astandrik
Copy link
Collaborator Author

bugbot run

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik
Copy link
Collaborator Author

bugbot run

cursor[bot]
cursor bot reviewed Jul 23, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!

Was this report helpful? Give feedback by reacting with 👍 or 👎

Raubzeug
Raubzeug requested changes Jul 24, 2025
View reviewed changes
src/containers/Tenant/Diagnostics/TenantOverview/TenantDashboard/TenantDashboard.tsx Outdated
const [hasSuccessfulChart, setHasSuccessfulChart] = React.useState<boolean>(false);

const isDashboardHidden = React.useMemo(() => {
return graphShardExists !== true && !hasSuccessfulChart;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!graphShardExists ?

@astandrik astandrik requested a review from Raubzeug July 24, 2025 08:22
@astandrik astandrik added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 602ca15 Jul 24, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.jumping-content-in-tabs branch July 24, 2025 09:18
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jul 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@cursor cursor[bot] cursor[bot] left review comments

@Raubzeug Raubzeug Raubzeug approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov artemmufazalov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: jumping content in database tabs
2 participants
@astandrik @Raubzeug