feat(VDisk): add replication progress, remaining time, donors info #2588

Copilot · 2025-07-21T08:26:53Z

This PR enhances the VDisk page to display additional replication information as requested in the issue. The changes add three key pieces of information that are already available in the API but were not being displayed in the UI:

Changes Made

1. Replication Progress

Added a visual progress bar showing completion percentage
Uses the existing ProgressViewer component for consistency
Displays as X% / 100% format with color-coded progress indication

2. Remaining Time

Shows estimated time remaining for replication completion
Uses the existing formatUptimeInSeconds utility for consistent time formatting
Displays in human-readable format (e.g., "10m 48s", "2h 15m", "1d 3h")

3. Donors List

Displays comma-separated list of donor VDisk IDs
Shows in format: NodeId-PDiskId-VSlotId (e.g., "4-1002-1004")
Uses existing helper functions for VDisk ID formatting

4. Tooltip Enhancement

Updated VDisk hover tooltips to also show replication progress and remaining time
Maintains consistency between main page and popup displays

Implementation Details

Files Modified:

src/components/VDiskInfo/VDiskInfo.tsx - Enhanced main VDisk info display
src/components/VDiskInfo/i18n/en.json - Added translation keys
src/components/VDiskPopup/VDiskPopup.tsx - Enhanced VDisk tooltips

Technical Approach:

Reused existing components (ProgressViewer, formatUptimeInSeconds)
All new fields use existing API data types (ReplicationProgress, ReplicationSecondsRemaining, Donors)
Minimal code changes with maximum impact
Maintains consistent UI patterns and styling

Verification

The implementation correctly processes the JSON data shown in the issue image:

ReplicationProgress: 0.345547 → displays as "35%" with progress bar
ReplicationSecondsRemaining: 648 → displays as "10m 48s"
Donors array → displays as comma-separated VDisk IDs

Both the main VDisk page and VDisk tooltips now provide comprehensive replication status information to help users monitor VDisk replication progress effectively.

Fixes #2290.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total	Passed	Failed	Flaky	Skipped
354	348	0	4	2

Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.20 MB | Main: 85.20 MB
Diff: +7.40 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information

Test recordings for failed tests are available in the full report.
Bundle size is measured for the entire 'dist' directory.
📊 indicates links to detailed reports.
🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>

adameat · 2025-07-22T05:33:59Z

that's what you did:

we only need fields with replication progress and time remaining when disk is not replicated (Replicated=false). Otherwise they should be hidden.
progress of replication is a good thing. 100% should be displayed only once and always in a green color.

- Only show replication progress and time remaining when disk is not replicated (Replicated=false) - Add inverseColorize=true to make 100% progress show as green instead of red - Update both VDiskInfo and VDiskPopup components to respect replication status Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot · 2025-07-22T05:46:04Z

that's what you did:

...

Fixed both issues in commit 3740536:

Conditional display: Replication progress and time remaining fields now only appear when Replicated=false. When a disk is fully replicated (Replicated=true), these fields are completely hidden.
Color correction: Added inverseColorize=true to the ProgressViewer component so that 100% replication progress displays in green color instead of red. This inverts the standard coloring logic where high percentages (95%+) are usually considered "danger" - but for replication, 100% completion is actually "good".

The changes affect both the main VDisk info display and the VDisk tooltips to maintain consistency across the UI.

adameat

values in tooltip don't look like others - wrong alignment

replication progress shows red color. but it should be green always.

donors are written two times

when vdisk state is not ok, it's always non replicated - no need to write replication progress and remainng time either

…licate donors Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot · 2025-07-22T10:12:30Z

values in tooltip don't look like others - wrong alignment

...

Fixed all 4 issues in commit 763bb57:

Tooltip alignment: Replication progress and time remaining now display as simple text values matching other fields' alignment.
Progress color: Changed ProgressViewer to use dangerThreshold={0} and warningThreshold={0} with inverseColorize={true}, ensuring replication progress always displays in green.
Duplicate donors: Removed donors display from main VDisk info section, keeping only the separate "Donors" section with clickable links.
Unnecessary fields on non-OK state: Added condition VDiskState === EVDiskState.OK so replication progress and time remaining only show when disk state is OK.

adameat · 2025-07-22T10:28:45Z

values of replication progress and remaining time in tooltip still badly aligned. here is the screenshot:

here is an example of backend output: [groups.json](https://github.com/user-attachments/files/21364954/groups.json)

no need to write "7% / 100%" - just "7%" is enough. remove second value from the replication progress:

… alignment Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot · 2025-07-22T10:48:41Z

values of replication progress and remaining time in tooltip still badly aligned. here is the screenshot:
<img width="370" height="425" alt="image" src="https://github.com/user-attachments/assets/...

Fixed both issues in commit a7d356c:

Tooltip alignment: Changed labels to shorter versions: "Progress" instead of "Replication Progress" and "Remaining" instead of "Time Remaining". This ensures proper alignment within the 85px minimum width in size="s" tooltips.
Progress display format: Modified ProgressViewer to only show percentage (e.g., "7%") by updating the formatValues function to return only the percentage value and adding hideCapacity={true} to remove the "/ 100%" part.

The changes maintain consistency across both the main VDisk page and tooltip displays while fixing the alignment and format issues.

adameat · 2025-07-22T10:55:13Z

very good!
the only thing to fix: list of donors can't be seen anymore. and in tooltip they are shown as all zeros.

to fix donors please consider backend data in attached file:
groups.json
and
vdiskinfo (1).json

Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot · 2025-07-22T11:10:32Z

very good!
the only thing to fix: list of donors can't be seen anymore. and in tooltip they are shown as all zeros.

...

Fixed both issues in commit 1b181ee:

Donors list visibility: Re-added donors display to main VDisk info page. Donors now appear only when Replicated=false and VDiskState=OK, preventing clutter on fully replicated disks.
Zero values in tooltip: Enhanced donor processing logic in prepareDisks.ts to properly handle TVSlotId objects. The function now:
- Differentiates between full VDisk data (TVDiskStateInfo) and slot data (TVSlotId)
- For TVSlotId donors, creates proper StringifiedId as NodeId-PDiskId-VSlotId
- Filters out donors with invalid/empty IDs to prevent "0-0-0" entries

The fix ensures donors display correctly in both the main VDisk page and tooltips, showing proper VDisk IDs instead of zeros.

adameat · 2025-07-22T12:05:49Z

change list of donors to show hyperlink for every donor to corresponding vDisk page. (parameters are: nodeId-pDiskId-vDiskSlotId)

Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot · 2025-07-22T12:20:19Z

change list of donors to show hyperlink for every donor to corresp...

Fixed in commit 2ebbecb. The donors list now displays as clickable hyperlinks that navigate to the corresponding VDisk page. Each donor ID is parsed to extract the nodeId, pDiskId, and vDiskSlotId parameters and creates navigation links using the existing getVDiskPagePath function and InternalLink component.

adameat · 2025-07-22T12:27:57Z

show donors as vertical list instead of horizontal list.

Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot · 2025-07-22T12:36:54Z

show donors as vertical list instead of horizontal list.

Changed donors list to display vertically instead of horizontally in commit 85191b0. The donors now appear as a vertical list with proper spacing using Flex direction="column" gap={1} instead of comma-separated inline links.

adameat

Initial plan

006f56f

Copilot AI assigned Copilot and antonkovalenko Jul 21, 2025

Copilot started work on behalf of antonkovalenko July 21, 2025 08:26 View session

Copilot AI and others added 2 commits July 21, 2025 08:43

Add replication progress, remaining time, and donors info to VDisk page

02709c3

Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>

Add replication progress and time remaining to VDisk tooltip

8c89486

Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] add more info to vdisk page~~ Add replication progress, remaining time, and donors info to VDisk page Jul 21, 2025

Copilot AI requested a review from antonkovalenko July 21, 2025 08:52

Copilot finished work on behalf of antonkovalenko July 21, 2025 08:52

Copilot started work on behalf of adameat July 22, 2025 05:34 View session

Copilot AI requested a review from adameat July 22, 2025 05:48

Copilot finished work on behalf of adameat July 22, 2025 05:48

adameat requested changes Jul 22, 2025

View reviewed changes

Copilot started work on behalf of adameat July 22, 2025 09:56 View session

Fix VDisk replication UI issues: state condition, progress color, dup…

763bb57

…licate donors Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot AI requested a review from adameat July 22, 2025 10:13

Copilot finished work on behalf of adameat July 22, 2025 10:13

Copilot started work on behalf of adameat July 22, 2025 10:28 View session

Fix replication UI issues: remove "/ 100%" format and improve tooltip…

a7d356c

… alignment Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot finished work on behalf of adameat July 22, 2025 10:49

Copilot started work on behalf of adameat July 22, 2025 10:55 View session

Fix donors display: add back to main UI and improve TVSlotId processing

1b181ee

Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot finished work on behalf of adameat July 22, 2025 11:41

Copilot started work on behalf of adameat July 22, 2025 12:00 View session

Copilot stopped work on behalf of adameat due to an error July 22, 2025 12:02
Copilot has encountered an error. See logs for additional details.

Copilot started work on behalf of adameat July 22, 2025 12:05 View session

Convert donors list to clickable links to VDisk pages

2ebbecb

Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot finished work on behalf of adameat July 22, 2025 12:21

Copilot started work on behalf of adameat July 22, 2025 12:28 View session

Change donors list to vertical layout instead of horizontal

85191b0

Co-authored-by: adameat <34044711+adameat@users.noreply.github.com>

Copilot finished work on behalf of adameat July 22, 2025 12:37

adameat previously approved these changes Jul 22, 2025

View reviewed changes

adameat marked this pull request as ready for review July 22, 2025 12:41

adameat requested review from artemmufazalov, astandrik and Raubzeug as code owners July 22, 2025 12:41

Raubzeug changed the title ~~Add replication progress, remaining time, and donors info to VDisk page~~ feat(VDisk): Add replication progress, remaining time, and donors info to VDisk page Jul 22, 2025

Raubzeug changed the title ~~feat(VDisk): Add replication progress, remaining time, and donors info to VDisk page~~ feat(VDisk): фdd replication progress, remaining time, donors info Jul 22, 2025

Raubzeug changed the title ~~feat(VDisk): фdd replication progress, remaining time, donors info~~ feat(VDisk): add replication progress, remaining time, donors info Jul 22, 2025

fix: review

4fbf95b

Raubzeug dismissed adameat’s stale review via 4fbf95b July 23, 2025 06:28

fix

55413db

Raubzeug approved these changes Jul 23, 2025

View reviewed changes

Raubzeug added this pull request to the merge queue Jul 23, 2025

Merged via the queue into main with commit f50686c Jul 23, 2025
7 checks passed

Raubzeug deleted the copilot/fix-2290 branch July 23, 2025 07:42

ydb-platform-bot mentioned this pull request Jul 22, 2025

chore(main): release 11.3.0 #2587

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(VDisk): add replication progress, remaining time, donors info #2588

feat(VDisk): add replication progress, remaining time, donors info #2588

Uh oh!

Copilot AI commented Jul 21, 2025 •

edited by github-actions bot

Loading

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat left a comment

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat left a comment

Uh oh!

Uh oh!

Uh oh!

feat(VDisk): add replication progress, remaining time, donors info #2588

feat(VDisk): add replication progress, remaining time, donors info #2588

Uh oh!

Conversation

Copilot AI commented Jul 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

1. Replication Progress

2. Remaining Time

3. Donors List

4. Tooltip Enhancement

Implementation Details

Verification

CI Results

Test Status: ⚠️ FLAKY

⏭️ Skipped Tests (2)

Bundle Size: 🔺

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat commented Jul 22, 2025

Uh oh!

Copilot AI commented Jul 22, 2025

Uh oh!

adameat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jul 21, 2025 •

edited by github-actions bot

Loading