Skip to content

feat: add Queries activities banner #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2025
Merged

feat: add Queries activities banner #2549

merged 4 commits into from
Jul 10, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jul 8, 2025 •
edited by github-actions bot
Loading

Closes #2444

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 4 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.11 MB | Main: 85.06 MB
Diff: +0.04 MB (0.05%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik marked this pull request as ready for review July 8, 2025 14:20
@astandrik astandrik requested a review from Copilot July 8, 2025 14:20
@astandrik
Copy link
Collaborator Author

bugbot run

cursor[bot]

This comment was marked as outdated.

Sign in to view

Copilot

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot July 8, 2025 14:42
@astandrik
Copy link
Collaborator Author

bugbot run

Copilot

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot July 8, 2025 15:01
@astandrik
Copy link
Collaborator Author

bugbot run

Copilot

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik astandrik requested a review from Copilot July 9, 2025 08:55
@astandrik
Copy link
Collaborator Author

bugbot run

Copilot

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@astandrik
Copy link
Collaborator Author

bugbot run

cursor[bot]

This comment was marked as outdated.

Sign in to view

Raubzeug
Raubzeug requested changes Jul 10, 2025
View reviewed changes
src/components/QueriesActivityBar/i18n/en.json Outdated
@@ -0,0 +1,10 @@
{
"title": "Queries Activity",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use naming according to https://nda.ya.ru/t/3mmvfnW37GJ2rU

src/components/MetricChart/MetricChart.scss Outdated
border: none;
}

&_fullWidth {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need it here? In components you pass width directly via styles property.

@astandrik astandrik requested a review from Copilot July 10, 2025 13:01
Copilot

This comment was marked as off-topic.

Sign in to view

@astandrik
Copy link
Collaborator Author

bugbot run

cursor[bot]

This comment was marked as off-topic.

Sign in to view

@astandrik astandrik requested a review from Raubzeug July 10, 2025 13:09
Raubzeug
Raubzeug requested changes Jul 10, 2025
View reviewed changes
src/components/MetricChart/MetricChart.tsx Outdated
<div className={b('title')}>{title}</div>
<Flex className={b('title')} justifyContent="space-between" alignItems="center">
<div>{title}</div>
{withTimeframeSelector &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do u think about doing a prop like renderChartToolbar and pass whatever user of this component needs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its overengineering =)

Copy link
Collaborator Author

@astandrik astandrik Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why not ¯\_(ツ)_/¯

@ydb-platform ydb-platform deleted a comment from Copilot AI Jul 10, 2025
@astandrik astandrik requested a review from Raubzeug July 10, 2025 13:58
@astandrik astandrik added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit dcfca43 Jul 10, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2444 branch July 10, 2025 16:06
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@cursor cursor[bot] cursor[bot] left review comments

@Raubzeug Raubzeug Raubzeug approved these changes

@artemmufazalov artemmufazalov Awaiting requested review from artemmufazalov artemmufazalov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Queries activities banner
2 participants
@astandrik @Raubzeug