Skip to content

feat!: update to uikit7 #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 9, 2025
Merged

feat!: update to uikit7 #2544

merged 14 commits into from
Jul 9, 2025

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Jul 7, 2025

closes #2144
Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 349 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 85.06 MB | Main: 84.01 MB
Diff: +1.05 MB (1.26%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik
Copy link
Collaborator

bugbot run

Copilot

This comment was marked as off-topic.

cursor[bot]

This comment was marked as outdated.

@astandrik
Copy link
Collaborator

  1. Unmigrated anchorRef Usage
    • File: src/containers/ReduxTooltip/ReduxTooltip.js
    • Lines: 49, 62
    • Issue: Still using deprecated anchorRef prop instead of anchorElement
    • Fix needed:
      // Line 49 - should be:
      anchorElement={fakeAnchor.current}
      
      // Line 62 - should be:
      anchorElement={anchor}

@astandrik
Copy link
Collaborator

  1. Unmigrated contentClassName
    • File: src/containers/ReduxTooltip/ReduxTooltip.js
    • Line: 48
    • Issue: Using deprecated contentClassName prop
    • Fix needed: Should use className on Popup and wrap content in a div

@Raubzeug
Copy link
Contributor Author

Raubzeug commented Jul 7, 2025

  • ReduxTooltip

Decided not to fix it right now, cause we want to get rid of this component (#2342)

Copy link
Collaborator

@astandrik astandrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/ContentWithPopup/ContentWithPopup.tsx

'onOutsideClick' is deprecated.ts(6385)
Popup.d.ts(69, 8): The declaration was marked as deprecated here.
(property) PopupProps.onOutsideClick?: ((event: MouseEvent) => void) | undefined
This callback will be called when click is outside of elements of "top layer" This behaviour could be disabled with disableOutsideClick option

@deprecated — Use onOpenChange instead

@Raubzeug Raubzeug requested a review from astandrik July 9, 2025 08:34
@astandrik astandrik requested a review from Copilot July 9, 2025 08:35
@astandrik
Copy link
Collaborator

bugbot run

Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

astandrik
astandrik previously approved these changes Jul 9, 2025
@astandrik astandrik requested a review from Copilot July 9, 2025 08:46
@astandrik
Copy link
Collaborator

bugbot run

Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@astandrik
Copy link
Collaborator

bugbot run

cursor[bot]

This comment was marked as outdated.

@Raubzeug
Copy link
Contributor Author

Raubzeug commented Jul 9, 2025

bugbot run

1 similar comment
@astandrik
Copy link
Collaborator

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: UsageLabel Component Overload Styling Missing

The UsageLabel component lost its overloadThreshold functionality during the UIKit migration. Previously, this prop (defaulting to 90) applied special "overload" styling when the value exceeded the threshold. The functionality was completely removed, including the overloadThreshold prop, its conditional styling logic, and associated SCSS, resulting in a loss of visual indication for high usage values.

src/components/UsageLabel/UsageLabel.tsx#L3-L14

interface UsageLabelProps extends Omit<LabelProps, 'value'> {
value: number | string;
}
export function UsageLabel({value, theme, ...props}: UsageLabelProps) {
return (
<Label theme={theme} {...props}>
{value || 0}%
</Label>
);
}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@Raubzeug Raubzeug added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit 9716a69 Jul 9, 2025
8 checks passed
@Raubzeug Raubzeug deleted the uikit7 branch July 9, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to uikit7
2 participants