Skip to content

fix: require ConnectStatus only for network table #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

fix: require ConnectStatus only for network table #2510

merged 1 commit into from
Jun 30, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jun 30, 2025 •
edited by github-actions bot
Loading

Closes #2502

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 1 5
Test Changes Summary ⏭️3

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

Bundle Size: ✅

Current: 84.01 MB | Main: 84.01 MB
Diff: +1.38 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov marked this pull request as ready for review June 30, 2025 10:11
@artemmufazalov artemmufazalov added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit d9a049f Jun 30, 2025
5 checks passed
@artemmufazalov artemmufazalov deleted the 2502-fix-nodes branch June 30, 2025 10:20
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astandrik astandrik astandrik approved these changes

@Raubzeug Raubzeug Raubzeug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not require ConnectStatus in Nodes Host column
3 participants
@artemmufazalov @astandrik @Raubzeug