Skip to content

fix: network error and incorrect backend response for operations #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jun 26, 2025

Closes #2488

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 1 5
Test Changes Summary ✨3 ⏭️3

✨ New Tests (3)

  1. shows error state when operations request returns network error (tenant/diagnostics/tabs/operations.test.ts)
  2. handles malformed response without operations array (tenant/diagnostics/tabs/operations.test.ts)
  3. stops pagination when receiving malformed response after valid data (tenant/diagnostics/tabs/operations.test.ts)

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

Bundle Size: ✅

Current: 84.00 MB | Main: 84.00 MB
Diff: +0.61 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot

This comment was marked as resolved.

@ydb-platform ydb-platform deleted a comment from Copilot AI Jun 26, 2025
@ydb-platform ydb-platform deleted a comment from Copilot AI Jun 26, 2025
@astandrik astandrik added this pull request to the merge queue Jun 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 26, 2025
@astandrik astandrik added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit df6342b Jun 26, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2488 branch June 26, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: handle incorrect response for operations
2 participants