Skip to content

fix: interface blinks on reload with dark theme #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Jun 25, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
344 338 0 1 5
Test Changes Summary ⏭️3 🗑️2

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

🗑️ Deleted Tests (2)

  1. shows access denied when operations request returns 403 (tenant/diagnostics/tabs/operations.test.ts)
  2. loads all operations when scrolling to the bottom multiple times (tenant/diagnostics/tabs/operations.test.ts)

Bundle Size: ✅

Current: 84.00 MB | Main: 84.00 MB
Diff: +0.25 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug linked an issue Jun 25, 2025 that may be closed by this pull request
@astandrik
Copy link
Collaborator

Could you provide description please of how (and where) it works now, where it wasn't working and what is #2d2c33 ?
Such changes in global index.html looks a bit suspicious to me

@Raubzeug
Copy link
Contributor Author

Raubzeug commented Jun 26, 2025

Could you provide description please of how (and where) it works now, where it wasn't working and what is #2d2c33 ? Such changes in global index.html looks a bit suspicious to me

#2d2c33 - background color in dark theme.
For now if you reload interface in dark theme, white color will blink (if throttle network). This PR fixes it.

@Raubzeug Raubzeug added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit d6f23a3 Jun 30, 2025
7 checks passed
@Raubzeug Raubzeug deleted the ydb-fix-blicking branch June 30, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface blinks on reload with dark theme
2 participants