Skip to content

feat(Tenants): add network column #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

feat(Tenants): add network column #2478

merged 1 commit into from
Jun 30, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jun 24, 2025

Closes #1925

Stand: https://nda.ya.ru/t/TPpOcAN57Fpbjh

You need to turn on experiment "Show network utilization"

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 1 5
Test Changes Summary ⏭️3

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

Bundle Size: ✅

Current: 84.00 MB | Main: 84.00 MB
Diff: +1.94 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov changed the title feat(Tenants): add network columns feat(Tenants): add network column Jun 27, 2025
@artemmufazalov artemmufazalov marked this pull request as ready for review June 27, 2025 12:46
@astandrik astandrik requested a review from Copilot June 30, 2025 08:19
@astandrik
Copy link
Collaborator

bugbot run

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a network column to the Tenants table when the "Show network utilization" experiment is enabled.

  • New imports and constants (formatBytes, EMPTY_DATA_PLACEHOLDER, SHOW_NETWORK_UTILIZATION) are added to support the feature.
  • A new setting (showNetworkUtilization) is used to conditionally render the "Network" column with appropriate formatting.
  • The columns array is updated to include the "Network" column with sorting and rendering logic.
Comments suppressed due to low confidence (1)

src/containers/Tenants/Tenants.tsx:243

  • Verify that the isNumeric function correctly handles all the expected formats for NetworkWriteThroughput; consider adding a comment or a unit test if there are edge cases.
                    if (!isNumeric(NetworkWriteThroughput)) {

header: 'Network',
width: 120,
align: DataTable.RIGHT,
defaultOrder: DataTable.DESCENDING,
Copy link
Preview

Copilot AI Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a brief comment here to clarify why NetworkWriteThroughput defaults to 0 to improve code readability.

Suggested change
defaultOrder: DataTable.DESCENDING,
defaultOrder: DataTable.DESCENDING,
// Defaulting NetworkWriteThroughput to 0 to represent missing data or no network activity.

Copilot uses AI. Check for mistakes.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@artemmufazalov artemmufazalov added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit f3b573a Jun 30, 2025
10 checks passed
@artemmufazalov artemmufazalov deleted the 1925-dbs-network branch June 30, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for network columns on database list
3 participants