fix(Cluster): use cluster name if title is empty string #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jun 20, 2025
| @@ -147,7 +147,7 @@ export function useClusterBaseInfo() { | |||
| // Name: ydb_vla_dev02 | |||
| // Title: YDB DEV VLA02 | |||
| const clusterName = name ?? clusterNameFromQuery ?? undefined; | |||
| const clusterTitle = title ?? clusterName; | |||
| const clusterTitle = title || clusterName; | |||
There was a problem hiding this comment.
Cluster title may be an empty string.
?? makes clusterTitle an empty string but clusterName should be used for correct display
artemmufazalov
changed the title
Raubzeug
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️1
⏭️ Skipped Tests (1)
Bundle Size: ✅
Current: 83.90 MB | Main: 83.90 MB
Diff: 0.04 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information