Skip to content

chore: run tests on actual commit not on merge commit #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jun 4, 2025

Closes #2367

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 316 0 2 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.65 MB | Main: 83.65 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow to run tests on the actual commit from the pull request instead of the merge commit generated by GitHub.

  • Updates the checkout step in the quality.yml workflow
  • Uses the pull request head SHA to determine the reference for testing
Comments suppressed due to low confidence (1)

.github/workflows/quality.yml:27

  • Consider adding an inline comment to clarify why this reference is used, which can help future maintainers understand the rationale for testing on the actual commit rather than the merge commit.
ref: ${{ github.event.pull_request.head.sha || github.sha }}

@astandrik astandrik added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit e4d4ae8 Jun 5, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2367 branch June 5, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: run tests on actual commit not on merge commit
2 participants