fix: table is broken because of batching #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the table was broken due to batching by introducing a new optional flag (noBatching) to bypass the request batcher when needed.
- Introduces the noBatching flag in the table reducer and propagates it through the table components
- Adjusts the data fetching logic to conditionally bypass batching
- Updates context and layout components to support the new noBatching flag
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/reducers/tableData.ts | Adds the noBatching flag and conditionally bypasses the request batcher when true |
| src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx | Passes the noBatching prop to the table component to disable batching when needed |
| src/components/PaginatedTable/TableChunk.tsx | Retrieves noBatching from context and includes it in the query parameters |
| src/components/PaginatedTable/PaginatedTableWithLayout.tsx | Extends the layout component to accept and pass the noBatching prop |
| src/components/PaginatedTable/PaginatedTableContext.tsx | Updates the table context and provider to include and propagate the noBatching flag |
Raubzeug
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2349
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.65 MB | Main: 83.65 MB
Diff: +1.22 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information