Skip to content

feat: find out performance issue with big tables of nodes #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented May 27, 2025

Closes #2193

CI Results

Test Status: ❌ FAILED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
318 307 10 1 0

😟 No changes in tests. πŸ˜•

Bundle Size: πŸ”Ί

Current: 83.63 MB | Main: 83.62 MB
Diff: +5.97 KB (0.01%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

@astandrik astandrik requested a review from Copilot May 27, 2025 17:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR targets performance issues in tables with many nodes by introducing a new virtualized rendering approach and improving scroll-based chunk management.

  • Introduces the useVirtualizedTbodies hook to render table bodies with spacer rows and active chunk elements.
  • Updates the overscan count in the useScrollBasedChunks hook from 1 to 15 and adjusts the default pagination limit from 20 to 50.
  • Refactors TableChunk to remove the isActive flag and conditionally render content based on visible row range.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/components/PaginatedTable/useVirtualizedTbodies.tsx New hook for virtualized tbody rendering with calculated spacer rows.
src/components/PaginatedTable/useScrollBasedChunks.ts Updates to overscan count and revised logic to return visible row range.
src/components/PaginatedTable/TableChunk.tsx Refactor to remove isActive flag and filter content by visible range.
src/components/PaginatedTable/PaginatedTable.tsx Integration of virtualized rendering and updated pagination limit.

@astandrik astandrik closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find out performance issue with big tables of nodes
1 participant