Skip to content

feat(Tenants): pass full db data to onDelete #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented May 26, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.62 MB | Main: 83.62 MB
Diff: 0.52 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

menuItems.push({
text: i18n('remove'),
iconStart: <TrashBin />,
action: () => {
uiFactory.onDeleteDB?.({
clusterName,
databaseId,
databaseName,
databaseData: row,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want always show edit button in database actions similar to Edit, if some data is missing, there will be stub with an error

@artemmufazalov artemmufazalov added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit b966aaa May 27, 2025
10 of 11 checks passed
@artemmufazalov artemmufazalov deleted the delete-db branch May 27, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants