fix(Versions): properly include nodes with defined roles in other group #2327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested review from
Raubzeug and
astandrik
and removed request for
astandrik and
Raubzeug
artemmufazalov
force-pushed
the
2320-fix-versions
branch
from
6362592 to
e0b7118
Compare
Raubzeug
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2320
Problem: node with
Bootstrapperwas missing in the list, because it was neither storage, nor tenant and it doesn't satisfy condition!Rolesthat we had previously.Solution: added all nodes, that are not included in Storage or Tenant group to Other group
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 83.62 MB | Main: 83.62 MB
Diff: +0.36 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information