Skip to content

fix: columns width #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: columns width #2229

merged 1 commit into from
Apr 29, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 29, 2025

Stand

missed max instruction
telegram-cloud-photo-size-2-5226642313953014970-y

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
318 317 0 1 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.38 MB | Main: 83.38 MB
Diff: +0.10 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot April 29, 2025 14:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the column width calculation in the storage settings by ensuring the calculated physical disk width does not fall below a given minimum threshold.

  • Update the calculation of calculatedPDiskWidth to use Math.max for enforcing a minimum width
  • Adjust the disk container width calculation accordingly
Comments suppressed due to low confidence (1)

src/containers/Storage/utils/useStorageColumnsSettings.ts:26

  • Consider adding test cases to cover the scenario where the computed width is below PDISK_MIN_WIDTH to ensure that the minimum width enforcement works as expected.
const calculatedPDiskWidth = Math.max(

@astandrik astandrik added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit c0b3efe Apr 29, 2025
9 checks passed
@astandrik astandrik deleted the astandrik.fix-pdisks-calc branch April 29, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants