Skip to content

feat(Tenants): correct links with relative path in balancer #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Apr 9, 2025

Closes #2105

Changes:

  • Fix links to Tenant page from Databases table with relative balancer
  • Fix links to Developer UI with relative balancer
  • Do not create links with nodes hosts, only with balancer

How to check changes

Add following changes to .env file and run app with npm run start

##### EM #####
REACT_APP_BACKEND=
REACT_APP_META_BACKEND=http://ui-dev-0.ydb.yandex.net/api/meta8780
META_YDB_BACKEND=

YDB DEV VLA02 and klg1-0561 have paths relative to meta as balancer and these paths are also a little different. UI without this fix makes incorrect links to Tenant page and Developer UI.

YDB RU PRESTABLE has full balancer value, it works on current version and should work after fix.

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
312 308 0 4 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 83.29 MB | Main: 83.29 MB
Diff: +1.54 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov requested a review from Copilot April 9, 2025 11:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

@@ -45,7 +45,6 @@ export interface TTenant {
StorageAllocatedSize?: string; // Actual database size
/** uint64 */
StorageMinAvailableSize?: string;
Nodes?: TSystemStateInfo[];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nodes and MonitoringEndpoint requires additional param in endpoint (nodes=true), we don't sent this param and thus never have these fields in response

@artemmufazalov artemmufazalov marked this pull request as ready for review April 9, 2025 11:56
Copy link
Collaborator

@astandrik astandrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure we discussed this pr more than enough in pm =)

@artemmufazalov artemmufazalov added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit f427375 Apr 10, 2025
8 checks passed
@artemmufazalov artemmufazalov deleted the 2105-relative-balancer-value branch April 10, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build]: enable UI to work with relative balancer value
2 participants