Skip to content

feat: design query tab #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 7, 2025
Merged

feat: design query tab #2077

merged 18 commits into from
Apr 7, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Apr 1, 2025 •
edited by github-actions bot
Loading

Closes #2041

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
308 307 0 1 0
Test Changes Summary ✨19 🗑️14

✨ New Tests (19)

  1. Info tab shows main page elements (tenant/diagnostics/tabs/info.test.ts)
  2. Info tab shows resource utilization (tenant/diagnostics/tabs/info.test.ts)
  3. Info tab shows healthcheck status (tenant/diagnostics/tabs/info.test.ts)
  4. Nodes tab shows nodes table with memory viewer (tenant/diagnostics/tabs/nodes.test.ts)
  5. No runnning queries in Queries if no queries are running (tenant/diagnostics/tabs/queries.test.ts)
  6. Running query is shown if query is running (tenant/diagnostics/tabs/queries.test.ts)
  7. Query tab defaults to Top mode (tenant/diagnostics/tabs/queries.test.ts)
  8. Query Top tab shows expected column headers (tenant/diagnostics/tabs/queries.test.ts)
  9. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  10. Query tab can switch between Top and Running modes (tenant/diagnostics/tabs/queries.test.ts)
  11. Query tab allows changing between Per hour and Per minute views (tenant/diagnostics/tabs/queries.test.ts)
  12. Primary keys header is visible in Schema tab (tenant/diagnostics/tabs/schema.test.ts)
  13. Storage tab shows Groups and Nodes views (tenant/diagnostics/tabs/storage.test.ts)
  14. TopShards tab defaults to Immediate mode (tenant/diagnostics/tabs/topShards.test.ts)
  15. TopShards immediate tab shows all expected column headers (tenant/diagnostics/tabs/topShards.test.ts)
  16. TopShards history tab shows all expected column headers (tenant/diagnostics/tabs/topShards.test.ts)
  17. TopShards tab first row has values for all columns in Immediate mode (tenant/diagnostics/tabs/topShards.test.ts)
  18. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)
  19. TopShards tab can switch back to Immediate mode from Historical mode (tenant/diagnostics/tabs/topShards.test.ts)

🗑️ Deleted Tests (14)

  1. Info tab shows main page elements (tenant/diagnostics/diagnostics.test.ts)
  2. Info tab shows resource utilization (tenant/diagnostics/diagnostics.test.ts)
  3. Info tab shows healthcheck status (tenant/diagnostics/diagnostics.test.ts)
  4. Storage tab shows Groups and Nodes views (tenant/diagnostics/diagnostics.test.ts)
  5. Nodes tab shows nodes table with memory viewer (tenant/diagnostics/diagnostics.test.ts)
  6. Primary keys header is visible in Schema tab (tenant/diagnostics/diagnostics.test.ts)
  7. No runnning queries in Queries if no queries are running (tenant/diagnostics/diagnostics.test.ts)
  8. Running query is shown if query is running (tenant/diagnostics/diagnostics.test.ts)
  9. TopShards tab defaults to Immediate mode (tenant/diagnostics/diagnostics.test.ts)
  10. TopShards immediate tab shows all expected column headers (tenant/diagnostics/diagnostics.test.ts)
  11. TopShards history tab shows all expected column headers (tenant/diagnostics/diagnostics.test.ts)
  12. TopShards tab first row has values for all columns in Immediate mode (tenant/diagnostics/diagnostics.test.ts)
  13. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/diagnostics.test.ts)
  14. TopShards tab can switch back to Immediate mode from Historical mode (tenant/diagnostics/diagnostics.test.ts)

Bundle Size: 🔺

Current: 83.28 MB | Main: 83.27 MB
Diff: +0.02 MB (0.02%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik
Copy link
Collaborator Author

making design fixes - going to draft state

@astandrik astandrik marked this pull request as draft April 1, 2025 11:40
@astandrik astandrik marked this pull request as ready for review April 1, 2025 12:24
@astandrik
Copy link
Collaborator Author

Ready for review
Updated stand

astandrik
astandrik commented Apr 1, 2025
View reviewed changes
astandrik
astandrik commented Apr 1, 2025
View reviewed changes
artemmufazalov
artemmufazalov requested changes Apr 2, 2025
View reviewed changes
@astandrik astandrik requested a review from artemmufazalov April 2, 2025 10:50
@astandrik
Copy link
Collaborator Author

@artemmufazalov
Splitted Top and Running views
removed sortable and sortAccessor
fixed top-5 issue

Updated Stand

artemmufazalov
artemmufazalov requested changes Apr 2, 2025
View reviewed changes
@astandrik astandrik requested a review from artemmufazalov April 2, 2025 13:17
artemmufazalov
artemmufazalov previously approved these changes Apr 2, 2025
View reviewed changes
@astandrik astandrik force-pushed the astandrik.2041 branch 2 times, most recently from 2efdd22 to e190282 Compare April 3, 2025 16:35
@astandrik astandrik requested a review from artemmufazalov April 3, 2025 16:39
@astandrik
Copy link
Collaborator Author

Added tests
Splitted diagnostics tabs tests
rebased on main

Redeployed Stand

artemmufazalov
artemmufazalov previously approved these changes Apr 4, 2025
View reviewed changes
@astandrik
Copy link
Collaborator Author

astandrik commented Apr 4, 2025 •
edited
Loading

  1. We need to leave running queries sorting as it is on prod now
  2. For top queries - turn no-sort state to triangles facing down
  3. modify query for running queries Empty Query and null QueryStartAt in .sys/query_sessions #2109

@antonkovalenko antonkovalenko mentioned this pull request Apr 7, 2025
Closed
@astandrik
Copy link
Collaborator Author

@artemmufazalov fixed, redeployed stand

@astandrik
Copy link
Collaborator Author

@artemmufazalov added widths and redeployed stand

@astandrik astandrik added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 06d243d Apr 7, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2041 branch April 7, 2025 11:35
@ydb-platform-bot ydb-platform-bot mentioned this pull request Apr 7, 2025
Merged
@ydb-platform-bot ydb-platform-bot mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@Raubzeug Raubzeug Awaiting requested review from Raubzeug Raubzeug is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Queries Tab on a database page according to design
2 participants
@astandrik @artemmufazalov