test(ObjectSummary): properly find virtualized tree element #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jan 21, 2025
| @@ -181,8 +195,49 @@ export class ObjectSummary { | |||
| return true; | |||
| } | |||
|
|
|||
| async getTreeItem(text: string) { | |||
There was a problem hiding this comment.
It can locate elements both in visible and in virtualized part of the tree (first 2000px only)
artemmufazalov
force-pushed
the
1861-fix-e2e-tests
branch
from
0b16f6e to
a740854
Compare
artemmufazalov
commented
Jan 21, 2025
| const itemLocator = this.treeRows.filter({hasText: text}).first(); | ||
|
|
||
| // Default timeout is too big for such case | ||
| const timeout = 500; |
There was a problem hiding this comment.
I didn't use default timeouts here because they are too big for such case. In this method we assume, that the tree is present and already loaded with isTreeVisible and isTreeLoaded. We spend little time to check elements, since in the worst scenario there will be 10 loops - with default timeout (VISIBILITY_TIMEOUT) it may be more than 100 seconds for one function call (in my version max is about 7 seconds)
astandrik
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1861
Because of some changes in our tests or ydb docker, some of the tables, that we used in tests, occurred in the bottom virtualized part of the
SchemaTree. Previously our tests wasn't able to locate such elements.I added
getTreeItemmethod toObjectSummarytest class, this method can locate object not only in the visible part ofSchemaTree.CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.05 MB | Main: 80.05 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information