feat: download dump with all info #1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
requested review from
Raubzeug,
artemmufazalov and
AlinaBelousovaUX
Raubzeug
requested changes
Jan 21, 2025
| @@ -13,6 +13,10 @@ | |||
| "title.result": "Result", | |||
| "text_plan-svg": "Execution plan", | |||
| "text_open-new-tab": "Open in new tab", | |||
| "text_open-new-tab_description": "New tab", | |||
There was a problem hiding this comment.
This description seems to be redundant
| const diagnosticsData = { | ||
| ...queryResultsInfo, | ||
| database, | ||
| timestamp: new Date().toISOString(), |
There was a problem hiding this comment.
If I were user, I would expect that in timestamp field it is some query stats - start or finish. What do you think about renaming this property?
| queryResultsInfo={{ | ||
| ast: data.ast, | ||
| stats: data.stats, | ||
| queryText, |
There was a problem hiding this comment.
lets' move queryText on top, so it would be easier to identify what about diagnostics file is?
Comment on lines
147
to
153
| const url = URL.createObjectURL(blob); | ||
| const link = document.createElement('a'); | ||
| link.href = url; | ||
| link.download = `query-diagnostics-${new Date().getTime()}.json`; | ||
| document.body.appendChild(link); | ||
| link.click(); | ||
| document.body.removeChild(link); |
There was a problem hiding this comment.
maybe move this logic to helper?
|
stand redeployed |
|
As for me |
Raubzeug
requested changes
Jan 21, 2025
|
|
||
| const renderSwitcher = (props: ButtonProps) => { | ||
| return ( | ||
| <Button view="flat-secondary" loading={isLoading} disabled={isLoading} {...props}> |
There was a problem hiding this comment.
Lets add ActionTooltip for title.
Raubzeug
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #984
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 80.06 MB | Main: 80.05 MB
Diff: +9.74 KB (0.01%)
ℹ️ CI Information