Skip to content

chore(autocomplete): add supported types #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2025
Merged

chore(autocomplete): add supported types #1826

merged 2 commits into from
Jan 20, 2025

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Jan 15, 2025 •
edited by github-actions bot
Loading

closes #922

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
262 259 0 3 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 79.96 MB | Main: 79.96 MB
Diff: +1.31 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug requested a review from astandrik January 15, 2025 14:04
astandrik
astandrik requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@astandrik astandrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we modify src/types/index.ts and src/utils/query.ts for types mappings?

@Raubzeug Raubzeug requested a review from astandrik January 20, 2025 06:46
@Raubzeug Raubzeug force-pushed the add-types-constants-922 branch from 6068424 to 7f44131 Compare January 20, 2025 06:53
@Raubzeug Raubzeug added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit e99b217 Jan 20, 2025
7 checks passed
@Raubzeug Raubzeug deleted the add-types-constants-922 branch January 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astandrik astandrik astandrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new date types in autocomplete: Datetime64, Interval64, Timestamp64
2 participants
@Raubzeug @astandrik