feat: remove /meta/cluster #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide a brief explanation of why /meta/cluster is no longer required |
artemmufazalov
force-pushed
the
1613-remove-meta-cluster
branch
from
63c0b28 to
2ee064e
Compare
artemmufazalov
commented
Dec 16, 2024
Comment on lines
-40
to
-44
| Balancer?: string; // additional | ||
| Solomon?: string; // additional | ||
|
|
||
| TraceView?: TTraceView; | ||
| TraceCheck?: TTraceCheck; |
There was a problem hiding this comment.
These fields aren't actually present in viewer/cluster response, they were added while parsing meta/cluster
artemmufazalov
commented
Dec 16, 2024
| @@ -9,7 +8,6 @@ import type {TTraceCheck, TTraceView} from './trace'; | |||
| */ | |||
| export interface TClusterInfoV1 { | |||
| error?: string; | |||
| Name?: string; | |||
There was a problem hiding this comment.
There is no Name in viewer/cluster response anymore
artemmufazalov
force-pushed
the
1613-remove-meta-cluster
branch
from
2ee064e to
38c8622
Compare
astandrik
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1613
meta/clusterreturns information both from meta table andviewer/clusterhandler. it could be replaced by combination ofmeta/db_clustersandviewer/cluster.Why it's needed:
meta/clustermakes troubles when we use ip hashing strategy on the balancer, since all users requests are coming from meta-hostviewer/clusterandmeta/db_clustersfor different purposes, there is no need to have their data together,also they could work faster when they are separate
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 65.88 MB | Main: 65.88 MB
Diff: 2.42 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information