Skip to content

refactor: merge query reducers #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import React from 'react';
import {useHistory, useLocation} from 'react-router-dom';

import {parseQuery} from '../../../../../routes';
import {changeUserInput} from '../../../../../store/reducers/executeQuery';
import {
setTopQueriesFilters,
topQueriesApi,
} from '../../../../../store/reducers/executeTopQueries/executeTopQueries';
import {changeUserInput} from '../../../../../store/reducers/query/query';
import {
TENANT_DIAGNOSTICS_TABS_IDS,
TENANT_PAGE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {DateRange} from '../../../../components/DateRange';
import {Search} from '../../../../components/Search';
import {TableWithControlsLayout} from '../../../../components/TableWithControlsLayout/TableWithControlsLayout';
import {parseQuery} from '../../../../routes';
import {changeUserInput} from '../../../../store/reducers/executeQuery';
import {setTopQueriesFilters} from '../../../../store/reducers/executeTopQueries/executeTopQueries';
import {changeUserInput} from '../../../../store/reducers/query/query';
import {
TENANT_PAGE,
TENANT_PAGES_IDS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import React from 'react';
import {NavigationTree} from 'ydb-ui-components';

import {useCreateDirectoryFeatureAvailable} from '../../../../store/reducers/capabilities/hooks';
import {selectUserInput} from '../../../../store/reducers/executeQuery';
import {selectUserInput} from '../../../../store/reducers/query/query';
import {schemaApi} from '../../../../store/reducers/schema/schema';
import {tableSchemaDataApi} from '../../../../store/reducers/tableSchemaData';
import type {GetTableSchemaDataParams} from '../../../../store/reducers/tableSchemaData';
Expand Down
4 changes: 2 additions & 2 deletions src/containers/Tenant/Query/ExecuteResult/ExecuteResult.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import {LoaderWrapper} from '../../../../components/LoaderWrapper/LoaderWrapper'
import {QueryExecutionStatus} from '../../../../components/QueryExecutionStatus';
import {QueryResultTable} from '../../../../components/QueryResultTable/QueryResultTable';
import {disableFullscreen} from '../../../../store/reducers/fullscreen';
import type {QueryResult} from '../../../../store/reducers/query/types';
import type {TKqpStatsQuery} from '../../../../types/api/query';
import type {ValueOf} from '../../../../types/common';
import type {ExecuteQueryResult} from '../../../../types/store/executeQuery';
import {getArray} from '../../../../utils';
import {cn} from '../../../../utils/cn';
import {USE_SHOW_PLAN_SVG_KEY} from '../../../../utils/constants';
Expand Down Expand Up @@ -50,7 +50,7 @@ const resultOptionsIds = {
type SectionID = ValueOf<typeof resultOptionsIds>;

interface ExecuteResultProps {
result: ExecuteQueryResult;
result: QueryResult;
isResultsCollapsed?: boolean;
theme?: string;
tenantName: string;
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Tenant/Query/ExecuteResult/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {explainVersions} from '../../../../store/reducers/explainQuery/utils';
import {explainVersions} from '../../../../store/reducers/query/prepareQueryData';
import type {IQueryResult} from '../../../../types/store/query';
import {preparePlan, prepareSimplifiedPlan} from '../../../../utils/prepareQueryExplain';
import {parseQueryExplainPlan} from '../../../../utils/query';
Expand Down
6 changes: 3 additions & 3 deletions src/containers/Tenant/Query/ExplainResult/ExplainResult.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import Fullscreen from '../../../../components/Fullscreen/Fullscreen';
import {LoaderWrapper} from '../../../../components/LoaderWrapper/LoaderWrapper';
import {QueryExecutionStatus} from '../../../../components/QueryExecutionStatus';
import {disableFullscreen} from '../../../../store/reducers/fullscreen';
import type {QueryResult} from '../../../../store/reducers/query/types';
import type {ValueOf} from '../../../../types/common';
import type {ExplainQueryResult} from '../../../../types/store/executeQuery';
import {cn} from '../../../../utils/cn';
import {getStringifiedData} from '../../../../utils/dataFormatters/dataFormatters';
import {useTypedDispatch} from '../../../../utils/hooks';
Expand Down Expand Up @@ -59,7 +59,7 @@ const explainOptions = [

interface ExplainResultProps {
theme: string;
result: ExplainQueryResult;
result: QueryResult;
tenantName: string;
isResultsCollapsed?: boolean;
onCollapseResults: VoidFunction;
Expand All @@ -81,7 +81,7 @@ export function ExplainResult({
const [isPending, startTransition] = React.useTransition();
const {error, isLoading, queryId} = result;

const {plan: explain, ast, simplifiedPlan} = result.data || {};
const {preparedPlan: explain, ast, simplifiedPlan} = result.data || {};

React.useEffect(() => {
return () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {YDBGraph} from '../../../../../../components/Graph/Graph';
import type {PreparedExplainResponse} from '../../../../../../store/reducers/explainQuery/types';
import {explainVersions} from '../../../../../../store/reducers/explainQuery/utils';
import {explainVersions} from '../../../../../../store/reducers/query/prepareQueryData';
import type {PreparedPlan} from '../../../../../../store/reducers/query/types';
import {cn} from '../../../../../../utils/cn';
import i18n from '../../i18n';

Expand All @@ -9,7 +9,7 @@ import './Graph.scss';
const b = cn('ydb-query-explain-graph');

interface GraphProps {
explain: PreparedExplainResponse['plan'];
explain: PreparedPlan;
theme: string;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React from 'react';
import {Table, useTable} from '@gravity-ui/table';
import type {CellContext, ColumnDef, ExpandedState} from '@tanstack/react-table';

import type {SimplifiedPlanItem} from '../../../../../../store/reducers/explainQuery/types';
import type {SimplifiedPlanItem} from '../../../../../../store/reducers/query/types';
import {configuredNumeral} from '../../../../../../utils/numeral';
import {formatToMs} from '../../../../../../utils/timeParsers';
import {toExponential} from '../../../../../../utils/utils';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {SimplifiedPlanItem} from '../../../../../../../store/reducers/explainQuery/types';
import type {SimplifiedPlanItem} from '../../../../../../../store/reducers/query/types';
import type {ExtendedSimplifiesPlanItem} from '../types';
import {getExtendedTreeNodes} from '../utils';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {SimplifiedPlanItem} from '../../../../../../store/reducers/explainQuery/types';
import type {SimplifiedPlanItem} from '../../../../../../store/reducers/query/types';

export interface ExtendedSimplifiesPlanItem extends Omit<SimplifiedPlanItem, 'children'> {
lines?: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {SimplifiedPlanItem} from '../../../../../../store/reducers/explainQuery/types';
import type {SimplifiedPlanItem} from '../../../../../../store/reducers/query/types';
import {cn} from '../../../../../../utils/cn';

import type {ExtendedSimplifiesPlanItem} from './types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import {
selectQueriesHistory,
selectQueriesHistoryFilter,
setQueryHistoryFilter,
} from '../../../../store/reducers/executeQuery';
} from '../../../../store/reducers/query/query';
import type {QueryInHistory} from '../../../../store/reducers/query/types';
import {TENANT_QUERY_TABS_ID} from '../../../../store/reducers/tenant/constants';
import {setQueryTab} from '../../../../store/reducers/tenant/tenant';
import type {QueryInHistory} from '../../../../types/store/executeQuery';
import {cn} from '../../../../utils/cn';
import {formatDateTime} from '../../../../utils/dataFormatters/dataFormatters';
import {useTypedDispatch, useTypedSelector} from '../../../../utils/hooks';
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Tenant/Query/Query.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';

import {Helmet} from 'react-helmet-async';

import {changeUserInput} from '../../../store/reducers/executeQuery';
import {changeUserInput} from '../../../store/reducers/query/query';
import {TENANT_QUERY_TABS_ID} from '../../../store/reducers/tenant/constants';
import type {EPathType} from '../../../types/api/schema';
import {cn} from '../../../utils/cn';
Expand Down
21 changes: 10 additions & 11 deletions src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,21 @@ import {MonacoEditor} from '../../../../components/MonacoEditor/MonacoEditor';
import SplitPane from '../../../../components/SplitPane';
import {useTracingLevelOptionAvailable} from '../../../../store/reducers/capabilities/hooks';
import {
executeQueryApi,
goToNextQuery,
goToPreviousQuery,
queryApi,
saveQueryToHistory,
selectQueriesHistory,
selectQueriesHistoryCurrentIndex,
selectResult,
selectTenantPath,
selectUserInput,
setTenantPath,
} from '../../../../store/reducers/executeQuery';
import {explainQueryApi} from '../../../../store/reducers/explainQuery/explainQuery';
} from '../../../../store/reducers/query/query';
import type {QueryResult} from '../../../../store/reducers/query/types';
import {setQueryAction} from '../../../../store/reducers/queryActions/queryActions';
import {selectShowPreview, setShowPreview} from '../../../../store/reducers/schema/schema';
import type {EPathType} from '../../../../types/api/schema';
import {ResultType} from '../../../../types/store/executeQuery';
import type {QueryResult} from '../../../../types/store/executeQuery';
import type {QueryAction} from '../../../../types/store/query';
import {cn} from '../../../../utils/cn';
import {
Expand Down Expand Up @@ -104,8 +102,7 @@ export default function QueryEditor(props: QueryEditorProps) {
LAST_USED_QUERY_ACTION_KEY,
);

const [sendExecuteQuery] = executeQueryApi.useExecuteQueryMutation();
const [sendExplainQuery] = explainQueryApi.useExplainQueryMutation();
const [sendQuery] = queryApi.useUseSendQueryMutation();

React.useEffect(() => {
if (savedPath !== tenantName) {
Expand Down Expand Up @@ -147,7 +144,8 @@ export default function QueryEditor(props: QueryEditorProps) {
}
const queryId = uuidv4();

sendExecuteQuery({
sendQuery({
actionType: 'execute',
query,
database: tenantName,
querySettings,
Expand Down Expand Up @@ -180,7 +178,8 @@ export default function QueryEditor(props: QueryEditorProps) {

const queryId = uuidv4();

sendExplainQuery({
sendQuery({
actionType: 'explain',
query: input,
database: tenantName,
querySettings,
Expand Down Expand Up @@ -400,7 +399,7 @@ function Result({
return <Preview database={tenantName} path={path} type={type} />;
}

if (result?.type === ResultType.EXECUTE) {
if (result?.type === 'execute') {
return (
<ExecuteResult
result={result}
Expand All @@ -413,7 +412,7 @@ function Result({
);
}

if (result?.type === ResultType.EXPLAIN) {
if (result?.type === 'explain') {
return (
<ExplainResult
result={result}
Expand Down
2 changes: 1 addition & 1 deletion src/store/configureStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function _configureStore<
},
serializableCheck: {
ignoredPaths: ['tooltip.currentHoveredRef', 'api'],
ignoredActions: [UPDATE_REF, 'api/executeQuery/rejected'],
ignoredActions: [UPDATE_REF, 'api/sendQuery/rejected'],
},
}).concat(locationMiddleware, ...middleware),
});
Expand Down
4 changes: 2 additions & 2 deletions src/store/reducers/cancelQuery.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type {CancelActions} from '../../types/api/query';
import type {IQueryResult, QueryRequestParams} from '../../types/store/query';
import {isQueryErrorResponse, parseQueryAPIExecuteResponse} from '../../utils/query';
import {isQueryErrorResponse, parseQueryAPIResponse} from '../../utils/query';

import {api} from './api';

Expand Down Expand Up @@ -28,7 +28,7 @@ export const cancelQueryApi = api.injectEndpoints({
return {error: response};
}

const data = parseQueryAPIExecuteResponse(response);
const data = parseQueryAPIResponse(response);

return {data};
} catch (error) {
Expand Down
4 changes: 2 additions & 2 deletions src/store/reducers/cluster/utils.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type {TClusterInfoV2, TStorageStats} from '../../../types/api/cluster';
import type {ExecuteQueryResponse, KeyValueRow} from '../../../types/api/query';
import {parseQueryAPIExecuteResponse} from '../../../utils/query';
import {parseQueryAPIResponse} from '../../../utils/query';

import type {ClusterGroupsStats} from './types';

Expand Down Expand Up @@ -88,7 +88,7 @@ function getGroupStats(data?: KeyValueRow[] | TStorageStats[]) {
export const parseGroupsStatsQueryResponse = (
data: ExecuteQueryResponse | null,
): ClusterGroupsStats => {
const parsedData = parseQueryAPIExecuteResponse(data).resultSets?.[0]?.result;
const parsedData = parseQueryAPIResponse(data).resultSets?.[0]?.result;
return getGroupStats(parsedData);
};

Expand Down
6 changes: 3 additions & 3 deletions src/store/reducers/executeTopQueries/executeTopQueries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {isLikeRelative} from '@gravity-ui/date-utils';
import {createSlice} from '@reduxjs/toolkit';
import type {PayloadAction} from '@reduxjs/toolkit';

import {isQueryErrorResponse, parseQueryAPIExecuteResponse} from '../../../utils/query';
import {isQueryErrorResponse, parseQueryAPIResponse} from '../../../utils/query';
import {api} from '../api';

import type {TopQueriesFilters} from './types';
Expand Down Expand Up @@ -70,7 +70,7 @@ export const topQueriesApi = api.injectEndpoints({
throw response;
}

const data = parseQueryAPIExecuteResponse(response);
const data = parseQueryAPIResponse(response);
return {data};
} catch (error) {
return {error};
Expand Down Expand Up @@ -123,7 +123,7 @@ export const topQueriesApi = api.injectEndpoints({
throw response;
}

const data = parseQueryAPIExecuteResponse(response);
const data = parseQueryAPIResponse(response);

return {data};
} catch (error) {
Expand Down
100 changes: 0 additions & 100 deletions src/store/reducers/explainQuery/explainQuery.ts

This file was deleted.

Loading
Loading