feat: add control to execute forget command for an export #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Popover is cut when it's not enough place. Why not use native titles? |
Raubzeug
requested changes
Oct 29, 2024
| } | ||
|
|
||
| return ( | ||
| <div className={b('buttons-container')}> |
There was a problem hiding this comment.
Lets use Flex from uikit?
| @@ -13,6 +14,9 @@ import './CriticalActionDialog.scss'; | |||
| const b = cn('ydb-critical-dialog'); | |||
|
|
|||
| const parseError = (error: IResponseError) => { | |||
| if (error.data && 'issues' in error.data && error.data.issues) { | |||
| return <ResultIssues data={error.data} />; | |||
There was a problem hiding this comment.
Looks strange... What if we remove ydb-critical-dialog__error-icon in case when we show issues tree?
There was a problem hiding this comment.
Is seems formatting is broken when expand issues
| } | ||
|
|
||
| function OperationsActions({operation, database, refreshTable}: OperationsActionsProps) { | ||
| const [cancelOperation, {isLoading: isLoadingCancel}] = |
There was a problem hiding this comment.
As for me it would be nice to show success toast if action is completed. What do you think?
|
@Raubzeug changed popovers to ActionTooltip |
Raubzeug
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1415
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 79.19 MB | Main: 79.12 MB
Diff: +0.07 MB (0.09%)
ℹ️ CI Information