fix(ClusterMetricsCores): format value and capacity same way #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
reviewed
Oct 28, 2024
| * @returns size to format value to get required number of digits | ||
| * | ||
| * By default value converted to the next size when it's above 1000, | ||
| * so we have 900mb and 1gb. To extend it additional significantDigits could be set |
There was a problem hiding this comment.
I suppose mb and gb are not accurate examples as gb is 1024mb
There was a problem hiding this comment.
oh this terrible copy-paste -_-
astandrik
reviewed
Oct 28, 2024
| @@ -1,8 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Time ago decided not to support /ru localization and if change en keysets, remove ru version
There was a problem hiding this comment.
As far as I remember we decided to support ru localization
astandrik
reviewed
Oct 28, 2024
| @@ -0,0 +1,107 @@ | |||
| import {formatNumber, roundToPrecision} from '../dataFormatters/dataFormatters'; | |||
There was a problem hiding this comment.
I suppose formatNumber shouldn't be in bytesParsers as it has small relevance to bytes operations logics
astandrik
reviewed
Oct 28, 2024
astandrik
reviewed
Oct 28, 2024
| export const getNumberWithSignificantDigits = (value: number, significantDigits: number) => { | ||
| const multiplier = 10 ** significantDigits; | ||
|
|
||
| const thousandLevel = sizes.million.value * multiplier; |
astandrik
reviewed
Oct 28, 2024
astandrik
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔺
Current: 79.11 MB | Main: 79.10 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information