Added CI check for GCC #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running the CI pipeline with GCC alongside Clang by updating workflow configurations and modifying related actions.
- Introduces a compiler matrix in multiple GitHub workflow files to test with both gcc and clang.
- Updates build and installation actions to support gcc-13, along with adjustments in cache keys and presets.
- Adds type alias TSelf in rate limiter settings header for improved readability and consistency.
Reviewed Changes
Copilot reviewed 8 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| include/ydb-cpp-sdk/client/rate_limiter/rate_limiter.h | Adds type alias TSelf for settings structs |
| .github/workflows/warmup_cache.yaml | Updates caching key to account for compiler matrix |
| .github/workflows/tests.yaml | Adjusts matrix and concurrency groups to include compiler |
| .github/workflows/examples.yaml | Updates matrix and alters build directory reference in examples |
| .github/actions/prepare_vm/action.yaml | Adds installation steps for gcc-13/g++-13 and update alternatives |
| .github/actions/build/action.yaml | Introduces a new compiler input and updates preset names for build |
Files not reviewed (10)
- .devcontainer/Dockerfile: Language not supported
- .devcontainer/configure.sh: Language not supported
- CMakeLists.txt: Language not supported
- CMakePresets.json: Language not supported
- clang.toolchain: Language not supported
- include/ydb-cpp-sdk/client/CMakeLists.txt: Language not supported
- include/ydb-cpp-sdk/client/topic/CMakeLists.txt: Language not supported
- src/client/topic/CMakeLists.txt: Language not supported
- src/client/topic/impl/CMakeLists.txt: Language not supported
- util/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
.github/actions/build/action.yaml:25
- The build preset in the build step changed from 'release' to 'default', which may lead to an unintended configuration. Verify if 'default' is the intended preset for both clang and gcc builds, or if it should remain consistent with the configure step.
cmake --build --preset default -- -j$(nproc)
dcherednik
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.