[READY] LSP: Allow globs in GetProjectRootFiles #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some languages name the project description file after the root directory. I.e. `foo/foo.csproj` and `foo/foo.sln` in case of C#. This accomodates those language servers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
- Coverage 95.94% 95.90% -0.05%
==========================================
Files 84 84
Lines 8464 8465 +1
Branches 163 163
==========================================
- Hits 8121 8118 -3
- Misses 293 297 +4
Partials 50 50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages name the project description file after the root directory.
I.e.
foo/foo.csprojandfoo/foo.slnin case of C#.This accommodates those language servers.
This is the last part needed for users to be able to use Omnisharp-Roslyn through
GenericLanguageServer.We should still get #1752 working, if for no other reason, then not to drag ancient omnisharp version.
This change is