added change branch scenario where a change in packages causes dedupe to kick in

Author: bestander

test/commands/install.js

@@ -385,6 +385,50 @@ test("downgrade scenario", () => {
   });
 });
 
+test.only("install have a clean node_modules after lockfile update (branch switch scenario)", async () => {
+  // A@1 -> B@1
+  // B@2
+
+  // after package.json/lock file update
+
+  // A@1.2 -> B@1.2
+
+  // (deduped)
+
+  // A@1.2
+  // B@1.2
+
+  let cwd = path.join(fixturesLoc, "install-should-cleanup-when-package-json-changed");
+
+  await fs.copy(path.join(cwd, "fbkpm.lock.before"), path.join(cwd, "fbkpm.lock"));
+  await fs.copy(path.join(cwd, "package.json.before"), path.join(cwd, "package.json"));
+
+  return run({}, [], "install-should-cleanup-when-package-json-changed", async (config) => {
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-a/package.json"))).version, "1.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-b/package.json"))).version, "2.0.0");
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/dep-a/node_modules/dep-b/package.json"))).version, "1.0.0");
+
+    await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+    await fs.unlink(path.join(config.cwd, "package.json"));
+
+    await fs.copy(path.join(cwd, "fbkpm.lock.after"), path.join(cwd, "fbkpm.lock"));
+    await fs.copy(path.join(cwd, "package.json.after"), path.join(cwd, "package.json"));
+
+    return run({}, [], "install-should-cleanup-when-package-json-changed", async (config) => {
+      assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+        "node_modules/dep-a/package.json"))).version, "1.2.0");
+      assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+        "node_modules/dep-b/package.json"))).version, "1.2.0");
+
+      await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+      await fs.unlink(path.join(config.cwd, "package.json"));
+    });
+  });
+});
+
 test("uninstall should remove dependency from package.json, fbkpm.lock and node_modules", () => {
   let mirrorPath = "mirror-for-offline";
 
@@ -420,7 +464,7 @@ test("uninstall should remove dependency from package.json, fbkpm.lock and node_
   });
 });
 
-test.only("uninstall should remove subdependencies", () => {
+test("uninstall should remove subdependencies", () => {
   // A@1 -> B@1
   // C@1
 

test/fixtures/install/install-should-cleanup-when-package-json-changed/.npmrc

@@ -0,0 +1 @@
+kpm-offline-mirror=./mirror-for-offline

test/fixtures/install/install-should-cleanup-when-package-json-changed/fbkpm.lock.after

@@ -0,0 +1,10 @@
+dep-a@^1.2.0:
+  name dep-a
+  version "1.2.0"
+  resolved dep-a-1.2.0.tgz#1e0d57d4c2055944ab042b617a064dc2ce1308fb
+  dependencies:
+    dep-b "1.2.0"
+dep-b@^1.2.0:
+  name dep-b
+  version "1.2.0"
+  resolved dep-b-1.2.0.tgz#d82ed4984566c1aea13d3d369b231bf52b672de3

test/fixtures/install/install-should-cleanup-when-package-json-changed/fbkpm.lock.before

@@ -0,0 +1,14 @@
+dep-a@^1.0.0:
+  name dep-a
+  version "1.0.0"
+  resolved dep-a-1.0.0.tgz#d170a960654001b74bdee4747e71f744ecf0a24f
+  dependencies:
+    dep-b "1.0.0"
+dep-b@1.0.0:
+  name dep-b
+  version "1.0.0"
+  resolved dep-b-1.0.0.tgz#fa3fab4e36d8eb93ac74790748a30547e9cb0f3f
+dep-b@^2.0.0:
+  name dep-b
+  version "2.0.0"
+  resolved dep-b-2.0.0.tgz#7d2e5fefe8bfaf5f162dc9e07883966e84c264cd

test/fixtures/install/install-should-cleanup-when-package-json-changed/mirror-for-offline/dep-a-1.0.0.tgz

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "dep-a": "^1.2.0"
+  }
+}