added deep dependency uninstall test case

Author: bestander

src/package-request.js

@@ -262,6 +262,7 @@ export default class PackageRequest {
       // while we're fetching the package we have some idle time to warm the cache with
       // registry responses for known dependencies
       for (let name in info.dependencies) {
+        // TODO not needed for offline installation
         this.warmCacheIfRegistry(`${name}@${info.dependencies[name]}`);
       }
 

test/commands/install.js

@@ -419,3 +419,62 @@ test("uninstall should remove dependency from package.json, fbkpm.lock and node_
     await fs.unlink(path.join(config.cwd, "package.json.orig"));
   });
 });
+
+test.only("uninstall should remove subdependencies", () => {
+  // A@1 -> B@1
+  // C@1
+
+  // remove A
+
+  // C@1
+
+  let mirrorPath = "mirror-for-offline";
+
+  return run({}, [], "uninstall-should-remove-subdependencies", async (config, reporter) => {
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/dep-a/package.json"))).version,
+      "1.0.0"
+    );
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/dep-b/package.json"))).version,
+      "1.0.0"
+    );
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/dep-c/package.json"))).version,
+      "1.0.0"
+    );
+
+    await fs.copy(path.join(config.cwd, "fbkpm.lock"), path.join(config.cwd, "fbkpm.lock.orig"));
+    await fs.copy(path.join(config.cwd, "package.json"), path.join(config.cwd, "package.json.orig"));
+
+    await uninstall(config, reporter, {}, ["dep-a"]);
+
+    assert(!await fs.exists(path.join(config.cwd, "node_modules/dep-a")));
+    // TODO dep-b did not get removed
+    assert(!await fs.exists(path.join(config.cwd, "node_modules/dep-b")));
+    assert(await fs.exists(path.join(config.cwd, "node_modules/dep-c")));
+
+    assert(await fs.exists(path.join(config.cwd, `${mirrorPath}/dep-a-1.0.0.tgz`)));
+    assert(await fs.exists(path.join(config.cwd, `${mirrorPath}/dep-b-1.0.0.tgz`)));
+    assert(await fs.exists(path.join(config.cwd, `${mirrorPath}/dep-c-1.0.0.tgz`)));
+
+    assert.deepEqual(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "package.json"))).dependencies,
+      {"dep-c": "^1.0.0"}
+    );
+
+    let lockFileContent = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+    let lockFileLines = lockFileContent.split("\n").filter((line) => !!line);
+    assert.equal(lockFileLines.length, 4);
+    assert.equal(lockFileLines[0], "dep-c@^1.0.0:");
+
+    await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+    await fs.unlink(path.join(config.cwd, "package.json"));
+    await fs.copy(path.join(config.cwd, "fbkpm.lock.orig"), path.join(config.cwd, "fbkpm.lock"));
+    await fs.copy(path.join(config.cwd, "package.json.orig"), path.join(config.cwd, "package.json"));
+    await fs.unlink(path.join(config.cwd, "fbkpm.lock.orig"));
+    await fs.unlink(path.join(config.cwd, "package.json.orig"));
+  });
+});
+
+

test/fixtures/install/uninstall-should-remove-subdependencies/.npmrc

@@ -0,0 +1 @@
+kpm-offline-mirror=./mirror-for-offline

test/fixtures/install/uninstall-should-remove-subdependencies/fbkpm.lock

@@ -0,0 +1,14 @@
+dep-a@^1.0.0:
+  name dep-a
+  version "1.0.0"
+  resolved dep-a-1.0.0.tgz#d170a960654001b74bdee4747e71f744ecf0a24f
+  dependencies:
+    dep-b "1.0.0"
+dep-b@1.0.0:
+  name dep-b
+  version "1.0.0"
+  resolved dep-b-1.0.0.tgz#fa3fab4e36d8eb93ac74790748a30547e9cb0f3f
+dep-c@^1.0.0:
+  name dep-c
+  version "1.0.0"
+  resolved dep-c-1.0.0.tgz#87be3f12250ea4b3a060a80663fe376670710775

test/fixtures/install/uninstall-should-remove-subdependencies/mirror-for-offline/dep-a-1.0.0.tgz

@@ -0,0 +1,6 @@
+{
+  "dependencies": {
+    "dep-a": "^1.0.0",
+    "dep-c": "^1.0.0"
+  }
+}