chore(compat) add eslint-plugin-import extensions
#3836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
eslint-plugin-import extensions
merceyz
previously approved these changes
Dec 2, 2021
auto-merge was automatically disabled
December 2, 2021 17:32
Head branch was pushed to by a user without write access
|
I'm not sure what is wrong with the one test that failed. It seems to have been a test for pnpm. |
|
Yeah, those tests are flaky so you can just ignore them, nothing wrong with this PR. We need to fix them at some point but for now @arcanis will have to do the merge since he can ignore the failing CI checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
https://discord.com/channels/226791405589233664/226793713722982400/915944163747446794
eslint-plugin-importcounts yarn as a broken package manager and does not want to fix their dependency declarations this may change once npm also brakes later.import-js/eslint-plugin-import#2283
import-js/eslint-plugin-import#1434
...
How did you fix it?
Added
eslint-import-resolver-node,eslint-import-resolver-typescript,eslint-import-resolver-webpack, and@typescript-eslint/parseras optional peer dependencies in plugin-compat....
Checklist