VoiceModelはDisposed後でもIdやMetasJsonにアクセスできるべきというものああるため、それに準拠する #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

actions-commit-pr-dekiru-kun merged 1 commit into main from can-access-metadata-after-object-disposed

Apr 17, 2025

Owner

yamachu commented Apr 17, 2025

ref: https://discord.com/channels/879570910208733277/893889888208977960/1361959886790983750

https://github.com/VOICEVOX/voicevox_core/blob/2adba0fc86a99ba67ed002d57ed200c69ede67b4/docs/guide/dev/api-design.md
voicevox_coreのデザインガイドラインを参考に、fieldのアクセスに関する処理を追加


          VoiceModelはDisposed後でもIdやMetasJsonにアクセスできるべきというものああるため、それに準拠する

f264715

Owner Author

yamachu commented Apr 17, 2025

/mq

Contributor

github-actions bot commented Apr 17, 2025

Queuing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/14514367605

Contributor

github-actions bot commented Apr 17, 2025

Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/14514372353
You can view state by GitHub CLI below command:

gh run view --repo yamachu/VoicevoxCoreSharp 14514372353
gh run watch --repo yamachu/VoicevoxCoreSharp 14514372353

If you want to cancel the test, you can cancel it by GitHub CLI below command:

gh run cancel --repo yamachu/VoicevoxCoreSharp 14514372353

actions-commit-pr-dekiru-kun bot merged commit a8a5efd into main

14 checks passed

actions-commit-pr-dekiru-kun bot deleted the can-access-metadata-after-object-disposed branch

April 17, 2025 11:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet