Skip to content

UTF-8文字列と勘違いしていたため、VoiceModelIdが壊れていた #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

yamachu
Copy link
Owner

@yamachu yamachu commented Apr 17, 2025

uuidみたいに他の人が扱っていなければinterface上変わりないのでbreakingにはならない…はず…

@yamachu yamachu added the bug Something isn't working label Apr 17, 2025
@yamachu yamachu requested a review from Copilot April 17, 2025 10:56
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

uuidみたいに他の人が扱っていなければinterface上変わりないのでbreakingにはならない…はず…
@yamachu yamachu force-pushed the voicemodelid-is-uuid-like branch from 98c629d to 44218cd Compare April 17, 2025 10:57
@yamachu
Copy link
Owner Author

yamachu commented Apr 17, 2025

/mq

Copy link
Contributor

Copy link
Contributor

Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/14514119597
You can view state by GitHub CLI below command:

  • gh run view --repo yamachu/VoicevoxCoreSharp 14514119597
  • gh run watch --repo yamachu/VoicevoxCoreSharp 14514119597

If you want to cancel the test, you can cancel it by GitHub CLI below command:

  • gh run cancel --repo yamachu/VoicevoxCoreSharp 14514119597

@actions-commit-pr-dekiru-kun actions-commit-pr-dekiru-kun bot merged commit a310360 into main Apr 17, 2025
8 checks passed
@actions-commit-pr-dekiru-kun actions-commit-pr-dekiru-kun bot deleted the voicemodelid-is-uuid-like branch April 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant