モバイル対応のMAUIサンプルに更新 #172
Merged
モバイル対応のMAUIサンプルに更新 #172
+617
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
そのためgitignoreでそのファイルはignoreしておく
…やつを記述するファイルを用意して使ってもらうようにする
yamachu
force-pushed
the
maui-sample-renew
branch
2 times, most recently
from
4f1db11 to
6370e07
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MAUI sample for better mobile support of VoicevoxCoreSharp by refining native library loading and sample usage.
- Updated the README with mobile-specific usage instructions.
- Added iOS and Android implementations for native library resolution.
- Refactored MainPageViewModel to handle platform-specific paths, directory copying, and model loading.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/MAUI/README.md | Updated instructions and requirements for mobile deployment. |
| src/VoicevoxCoreSharp.MAUI/Platforms/iOS/CoreHelper.cs | Added native library resolver logic for iOS. |
| src/VoicevoxCoreSharp.MAUI/Platforms/Android/CoreHelper.cs | Added native library resolver logic for Android. |
| examples/MAUI/MainPageViewModel.cs | Refactored directory retrieval, file copying, and model loading with platform logic. |
| examples/MAUI/Platforms/iOS/Program.cs | Initialized CoreHelper early for proper native library loading on iOS. |
| examples/MAUI/Platforms/Android/MainApplication.cs | Initialized CoreHelper early for proper native library loading on Android. |
Comments suppressed due to low confidence (1)
examples/MAUI/MainPageViewModel.cs:273
- The recursive call to CopyDirectory is not awaited, which might lead to incomplete asynchronous operations; consider awaiting this call.
CopyDirectory(dir, destSubDir);
6370e07 to
5575358
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MAUI sample to support mobile environments by incorporating voicevox_core 0.16.0-preview.1. Key changes include:
- Updated README.md with instructions for model downloads and build/run commands for macOS, iOS, and Android.
- Added platform-specific CoreHelper implementations for iOS and Android to correctly resolve native libraries.
- Modified MainPageViewModel.cs to use platform-aware paths for loading dependencies and models.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/MAUI/README.md | Updated usage instructions and commands for voicevox_core 0.16.0-preview.1 |
| src/VoicevoxCoreSharp.MAUI/Platforms/iOS/CoreHelper.cs | Introduced native library resolver for iOS |
| src/VoicevoxCoreSharp.MAUI/Platforms/Android/CoreHelper.cs | Introduced native library resolver for Android |
| examples/MAUI/Platforms/iOS/Program.cs | Added initialization of CoreHelper before native library load |
| examples/MAUI/MainPageViewModel.cs | Updated dependency paths and directory copying for mobile platforms |
| examples/MAUI/Platforms/Android/MainApplication.cs | Added initialization of CoreHelper in the application constructor |
|
/mq |
|
Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/13871186794
If you want to cancel the test, you can cancel it by GitHub CLI below command:
|
yamachu
commented
Mar 15, 2025
| /// <summary> | ||
| /// Initialize VoicevoxCore for loading voicevox_core.framework | ||
| /// </summary> | ||
| /// <param name="overrideVoicevoxCoreDynamicLibraryPath">if pass `null`, using iOS default framework path.</param> |
There was a problem hiding this comment.
あっ、コピペしたままだから、iOSの内容のコメントになってる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #158
voicevox_core 0.16.0-preview.1 がリリースされたことにより、モバイルで本番モデルを使用しやすくなった
CoreSharpで利用可能であることを示したり、モバイル環境での利用方法を示すため、MAUIのサンプルを更新する