Skip to content

Update submodule #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Update submodule #163

merged 4 commits into from
Feb 20, 2025

Conversation

yamachu
Copy link
Owner

@yamachu yamachu commented Feb 20, 2025

No description provided.

UserDictWordクラスよりも多くのmemberが返ってくるようになっているので、それに対応
classに対応するものだけを取得するでも良いかもしれない
@yamachu yamachu added the breaking Breaking changes label Feb 20, 2025
@yamachu
Copy link
Owner Author

yamachu commented Feb 20, 2025

テストケースとしても、UserDictWordがめちゃくちゃ変わってるのでbreakingタグを付けておいた
Json周りの処理が確かに変わってるのでなるほどなーという感じ
C-Headerで定義されているメンバー以外の情報が出ているけれども、それを編集できる手段がない(?)ので大分breakingだなー…

@yamachu
Copy link
Owner Author

yamachu commented Feb 20, 2025

/mq

Copy link
Contributor

Copy link
Contributor

Testing: https://github.com/yamachu/VoicevoxCoreSharp/actions/runs/13436269617
You can view state by GitHub CLI below command:

  • gh run view --repo yamachu/VoicevoxCoreSharp 13436269617
  • gh run watch --repo yamachu/VoicevoxCoreSharp 13436269617

If you want to cancel the test, you can cancel it by GitHub CLI below command:

  • gh run cancel --repo yamachu/VoicevoxCoreSharp 13436269617

@actions-commit-pr-dekiru-kun actions-commit-pr-dekiru-kun bot merged commit bade1b8 into main Feb 20, 2025
14 checks passed
@actions-commit-pr-dekiru-kun actions-commit-pr-dekiru-kun bot deleted the update-submodule branch February 20, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant