-
-
Notifications
You must be signed in to change notification settings - Fork 863
feat: Optimize simple queries #3135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I guess this PR also fixes #3133. @abdulrhmansouda would you be able to review? Thanks! |
I fixed this problem when I changed the isComplexQuery function #3133. |
Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good so far.
Please fix the code style using composer pint
or composer pr
to run all quality tools. It will make the PR easier to review.
Thanks!
Released on v11.1.0, 🚀 thanks! |
The issues was for simple queries with complexe wheres, a sub query was used resulting in the following query :
resulting into an uneccessary temporary table, the query we would like to have would be this one :
On our app, the gains were massive, one of our datables would just timeout and with this change it load now in less than 5 seconds