Skip to content

feat: Implement CLP type parser to support special chars besides _ in field name (addresses yscope/velox#13). #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: release-0.293-clp-connector
Choose a base branch
from
Draft

feat: Implement CLP type parser to support special chars besides _ in field name (addresses yscope/velox#13). #67

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbb5157
Sync velox
anlowee Sep 11, 2025
c0695b0
Format
anlowee Sep 11, 2025
c17c680
Sync velox
anlowee Sep 15, 2025
1c38e95
Merge branch 'release-0.293-clp-connector' into xwei/handle-special-c…
anlowee Sep 15, 2025
41c30c6
Sync velox
anlowee Sep 16, 2025
4dc433d
Merge branch 'xwei/handle-special-chars' of github.com:anlowee/presto…
anlowee Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions presto-native-execution/presto_cpp/main/connectors/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ if(PRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR)
target_link_libraries(presto_connectors presto_flight_connector)
endif()

target_link_libraries(presto_connectors presto_velox_expr_conversion
velox_clp_connector velox_type_fbhive)
target_link_libraries(
presto_connectors presto_velox_expr_conversion velox_clp_connector
velox_type_fbhive velox_type_fbclp_parser)
3 changes: 2 additions & 1 deletion presto-native-execution/presto_cpp/main/connectors/PrestoToVeloxConnector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "presto_cpp/presto_protocol/connector/iceberg/IcebergConnectorProtocol.h"
#include "presto_cpp/presto_protocol/connector/tpch/TpchConnectorProtocol.h"

#include <velox/type/fbclp/ClpTypeParser.h>
#include <velox/type/fbhive/HiveTypeParser.h>
#include "velox/connectors/clp/ClpColumnHandle.h"
#include "velox/connectors/clp/ClpConnectorSplit.h"
Expand Down Expand Up @@ -1580,7 +1581,7 @@ ClpPrestoToVeloxConnector::toVeloxColumnHandle(
return std::make_unique<connector::clp::ClpColumnHandle>(
clpColumn->columnName,
clpColumn->originalColumnName,
typeParser.parse(clpColumn->columnType));
facebook::velox::type::fbclp::parseClpType(clpColumn->columnType));
}

std::unique_ptr<velox::connector::ConnectorTableHandle>
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Open in desktop
Submodule velox updated 10 files
+1 −0 velox/type/CMakeLists.txt
+45 −0 velox/type/fbclp/CMakeLists.txt
+68 −0 velox/type/fbclp/ClpParserUtil.cpp
+43 −0 velox/type/fbclp/ClpParserUtil.h
+55 −0 velox/type/fbclp/ClpScanner.h
+37 −0 velox/type/fbclp/ClpTypeParser.h
+76 −0 velox/type/fbclp/ClpTypeParser.ll
+156 −0 velox/type/fbclp/ClpTypeParser.yy
+25 −0 velox/type/fbclp/tests/CMakeLists.txt
+35 −0 velox/type/fbclp/tests/ClpTypeParserTest.cpp
Loading