Skip to content

build: Standardize asset containers to use official Ubuntu base images. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

build: Standardize asset containers to use official Ubuntu base images. #3

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e27486
change ubuntu references to ubuntu:jammy
PacificViking Jul 24, 2025
0d480b7
fix according to coderabbit recommendations
PacificViking Jul 30, 2025
2de68a1
lock gzip version (this was the reason for --allow-downgrades, it was…
PacificViking Jul 30, 2025
a0a0175
lock gzip version
PacificViking Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/elasticsearch/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ghcr.io/y-scope/clp/clp-core-dependencies-x86-ubuntu-jammy:main
FROM ubuntu:jammy

RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y \
Expand Down
6 changes: 3 additions & 3 deletions assets/gzip/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
# dependencies

# If there is any dedicated image available, you should build the benchmarking image on top of that
FROM ghcr.io/y-scope/clp/clp-core-dependencies-x86-ubuntu-jammy:main
FROM ubuntu:jammy

# Install necessary packages
RUN apt-get update \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y \
&& DEBIAN_FRONTEND=noninteractive apt-get install -y --allow-downgrades \
tmux \
vim \
gzip
gzip=1.10-4ubuntu4.1
Comment on lines +9 to +12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Reproducibility: consider pinning tmux and vim as well

You’ve pinned gzip; for full reproducibility, pin tmux and vim to Jammy archive versions too. If size matters more than full Vim, switch to vim-tiny.

🧰 Tools
🪛 Checkov (3.2.334)

[LOW] 1-12: Ensure that HEALTHCHECK instructions have been added to container images

(CKV_DOCKER_2)

[LOW] 1-12: Ensure that a user for the container has been created

(CKV_DOCKER_3)

🤖 Prompt for AI Agents 
In assets/gzip/Dockerfile around lines 9 to 12, tmux and vim are installed
without version pins, which can cause reproducibility issues. Update the apt-get
install command to specify exact versions of tmux and vim from the Jammy
archive, similar to how gzip is pinned. Alternatively, if image size is a
concern, replace vim with vim-tiny and pin its version accordingly to ensure
consistent builds.


2 changes: 1 addition & 1 deletion assets/overhead_test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# dependencies

# If there is any dedicated image available, you should build the benchmarking image on top of that
FROM ghcr.io/y-scope/clp/clp-core-dependencies-x86-ubuntu-jammy:main
FROM ubuntu:jammy

# Install necessary packages
RUN apt-get update \
Expand Down
2 changes: 1 addition & 1 deletion assets/template/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# dependencies

# If there is any dedicated image available, you should build the benchmarking image on top of that
FROM ghcr.io/y-scope/clp/clp-core-dependencies-x86-ubuntu-jammy:main
FROM ubuntu:jammy

# Install necessary packages
RUN apt-get update \
Expand Down