-
Notifications
You must be signed in to change notification settings - Fork 82
build(clp-package): Adopt uv + hatchling as the build and packaging backend for Python components (resolves #1396); Upgrade dependencies for Python components. #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
1f195bf
14c30fa
92c0961
0caddbb
c93ee6a
cd9aa66
72459fd
6fe93a1
cf28cae
3ef632f
464ad89
19453a8
8034e1e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,19 @@ | ||
[project] | ||
requires-python = ">= 3.9" | ||
|
||
[tool.poetry] | ||
name = "clp-package-utils" | ||
version = "0.5.2-dev" | ||
description = "Utilities for the CLP package." | ||
authors = ["YScope Inc. <dev@yscope.com>"] | ||
authors = [{name = "YScope Inc.", email = "dev@yscope.com"}] | ||
readme = "README.md" | ||
|
||
[tool.poetry.dependencies] | ||
python = ">= 3.9" | ||
Brotli = "^1.1.0" | ||
msgpack = "^1.0.7" | ||
psutil = "^7.1.0" | ||
pydantic = "^2.11.9" | ||
pymongo = "^4.7.2" | ||
PyYAML = "^6.0.1" | ||
requires-python = ">=3.9" | ||
dependencies = [ | ||
"Brotli>=1.1.0", | ||
"msgpack>=1.1.2", | ||
"psutil>=7.1.0", | ||
"pydantic>=2.12.0", | ||
"pymongo>=4.15.3", | ||
"PyYAML>=6.0.3", | ||
] | ||
|
||
[build-system] | ||
requires = ["poetry-core"] | ||
build-backend = "poetry.core.masonry.api" | ||
|
||
requires = ["hatchling"] | ||
build-backend = "hatchling.build" |
Large diffs are not rendered by default.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,25 @@ | ||
[project] | ||
requires-python = ">= 3.9" | ||
|
||
[tool.poetry] | ||
name = "clp-py-utils" | ||
version = "0.5.2-dev" | ||
description = "Utilities for other Python packages in CLP." | ||
authors = ["YScope Inc. <dev@yscope.com>"] | ||
authors = [{name = "YScope Inc.", email = "dev@yscope.com"}] | ||
readme = "README.md" | ||
|
||
[tool.poetry.dependencies] | ||
python = ">= 3.9" | ||
boto3 = "^1.35.81" | ||
# mariadb version must be compatible with libmariadev installed in runtime env. | ||
# See https://mariadb.com/docs/server/connect/programming-languages/python/install/#Dependencies | ||
mariadb = "~1.0.11" | ||
mysql-connector-python = "^8.2.0" | ||
pydantic = "^2.11.9" | ||
python-dotenv = "^1.0.1" | ||
python-Levenshtein = "~0.22" | ||
sqlalchemy = "~2.0" | ||
PyYAML = "^6.0.1" | ||
result = "^0.17.0" | ||
StrEnum = "^0.4.15" | ||
requires-python = ">=3.9" | ||
dependencies = [ | ||
"boto3>=1.40.50", | ||
# mariadb version must be compatible with libmariadev installed in runtime env. | ||
# See https://mariadb.com/docs/server/connect/programming-languages/python/install/#Dependencies | ||
"mariadb>=1.0.11,<1.1.dev0", | ||
"mysql-connector-python>=9.4.0", | ||
"pydantic>=2.12.0", | ||
"python-dotenv>=1.1.1", | ||
"python-Levenshtein>=0.27.1", | ||
"sqlalchemy>=2.0.44", | ||
"PyYAML>=6.0.3", | ||
"result>=0.17.0", | ||
"StrEnum>=0.4.15", | ||
junhaoliao marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
] | ||
|
||
[build-system] | ||
requires = ["poetry-core"] | ||
build-backend = "poetry.core.masonry.api" | ||
requires = ["hatchling"] | ||
build-backend = "hatchling.build" |
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this empty file has to be added. otherwise, |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All the changed Python source files in this PR are just the results of running There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I think these changes make sense: before this PR, there's no project name set in the |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align
requires-python
with the 3.10 floor.The PR mandate is to move every package to Python ≥3.10, yet Line 7 still advertises support down to 3.9. This leaves the wheel installable on 3.9, diverging from the documented requirement and increasing support risk. Please bump the constraint here (and ensure matching metadata elsewhere) to enforce the new floor.
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was decided that we should do the Python version requirement change in a separate PR to reduce review effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junhaoliao, understood! I'll note that the Python 3.10 migration is being handled separately.
Would you like me to create a GitHub issue to track this follow-up work? I can include a reference back to this PR and the discussion.
✏️ Learnings added
🧠 Learnings used