fix(web-search): Respect user location in search results #763
Conversation
junaid-shirur
requested review from
kalpadhwaryu,
shivamashtikar and
zereraz
as code owners
WalkthroughIntroduces a new function to generate a web-search system prompt using user context and updates the provider to consume it. Refactors search query prompt rendering to conditionally include sections only when data exists. No control-flow changes beyond replacing a static prompt with a generated one. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as Caller
participant Provider as WebSearch Provider
participant Prompts as Prompts Module
participant LLM as Model
UI->>Provider: webSearchQuestion(userCtx, params)
Provider->>Prompts: webSearchSystemPrompt(userCtx)
Prompts-->>Provider: systemPrompt (context-aware)
alt agentPrompt provided
Provider->>Provider: Append parsed agent prompt
end
Provider->>LLM: Invoke with systemPrompt (+agentPrompt), user input
LLM-->>Provider: Answer / Search query
Provider-->>UI: Result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @junaid-shirur, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to significantly improve the accuracy and relevance of web search results by integrating user location and timezone data into the search query process. The change ensures that the AI assistant provides more contextually appropriate and up-to-date information, especially for time-sensitive queries.
Highlights
- Enhanced Web Search Relevance: The web search functionality now incorporates the user's location and timezone when fetching results. This ensures that time-sensitive information, such as current events, prices, or business hours, is accurately presented based on the user's geographical context.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
server/ai/prompts.ts (1)
2348-2352: Optional: Avoid over-sharing PII in system promptsIncluding full “User-Details” (name/email/domain) in a general web-search system prompt may be unnecessary. Consider restricting to location/locale/timezone to reduce exposure.
server/ai/provider/index.ts (1)
1829-1841: Pass user geo/locale to provider layer for true location-aware searchEven with a better prompt, actual search ranking often depends on engine parameters (hl/gl, lr, uule, lat/lon). Consider threading user country/region/coords through ModelParams and provider implementations (e.g., Vertex/Google) to bias results server-side.
Proposed interface change (sketch):
// types export interface ModelParams { // ... userLocale?: { country?: string; region?: string; city?: string; lat?: number; lon?: number; tz?: string } } // provider usage params.userLocale && provider.setGeo(params.userLocale)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
server/ai/prompts.ts(4 hunks)server/ai/provider/index.ts(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
server/ai/provider/index.ts (2)
server/ai/prompts.ts (2)
searchQueryPrompt(1058-1447)webSearchSystemPrompt(2348-2352)server/ai/context.ts (1)
userContext(820-834)
server/ai/prompts.ts (1)
server/ai/context.ts (1)
userContext(820-834)
🔇 Additional comments (2)
server/ai/prompts.ts (1)
1-1: Replace static IST in userContext with dynamic timezone
In server/ai/context.ts (lines 823–833), userContext appends a hard-coded “Timezone: IST”, forcing all prompts to India time. Replace with atzvalue fromuser.timezone➔workspace.timezone➔Intl.DateTimeFormat().resolvedOptions().timeZone➔"UTC"and pass it intotoLocaleDateString/toLocaleTimeString.export const userContext = ({ user, workspace, }: PublicUserWorkspace): string => { - const now = new Date() - const currentDate = now.toLocaleDateString() // e.g., "11/10/2024" - const currentTime = now.toLocaleTimeString() // e.g., "10:14:03 AM" + const now = new Date() + // Prefer persisted user timezone/locale from profile or request; fall back to Intl + const tz = + user.timezone || + workspace.timezone || + Intl.DateTimeFormat().resolvedOptions().timeZone || + "UTC" + const currentDate = now.toLocaleDateString(undefined, { timeZone: tz }) + const currentTime = now.toLocaleTimeString(undefined, { timeZone: tz }) return `My Name is ${user.name} Email: ${user.email} Company: ${workspace.name} Company domain: ${workspace.domain} Current Time: ${currentTime} Today is: ${currentDate} - Timezone: IST` + Timezone: ${tz}` }Likely an incorrect or invalid review comment.
server/ai/provider/index.ts (1)
1483-1487: LGTM: Multi-line call improves readability; no behavior changeThe reformatted call to searchQueryPrompt with three arguments preserves semantics.
2 participants
Description
Testing
Additional Notes
Summary by CodeRabbit
New Features
Refactor