Skip to content

Conversation

MayankBansal2004
Copy link
Contributor

@MayankBansal2004 MayankBansal2004 commented Oct 10, 2025

Description

enabling calling button

Testing

tested locally.

Additional Notes

Summary by CodeRabbit

  • Bug Fixes
    • Restored the Users & Calls button in the sidebar, making it visible and interactive again.
    • Users can now access the Users & Calls section directly from the sidebar without workaround.
    • Icon display now matches the active UI element for clearer navigation.
    • No changes were made to routing, modals, or other behaviors—only the sidebar control was re-enabled.
    • Improves discoverability and consistency of the sidebar navigation.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MayankBansal2004, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on activating a previously disabled calling functionality within the application. It makes the 'Users & Calls' button in the sidebar visible and interactive, thereby integrating the feature into the user interface.

Highlights

  • Calling Feature Activation: The pull request enables the calling feature by uncommenting the relevant UI components and their associated icon imports in the sidebar.
  • Sidebar UI Update: The 'Users & Calls' button, previously commented out, is now active and visible in the application's sidebar, allowing users to interact with this functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Walkthrough

Re-enables the Users button in the sidebar by uncommenting the Users import from lucide-react and the corresponding UI block, making the Users & Calls toggle visible again. No routing or modal logic changes.

Changes

Cohort / File(s) Summary of Changes
Sidebar UI toggle re-enabled
frontend/src/components/Sidebar.tsx
Uncomments Users import from lucide-react and the Users toggle div, restoring the Users & Calls control to the sidebar. No additional behavioral changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • zereraz
  • shivamashtikar
  • kalpadhwaryu
  • junaid-shirur
  • devesh-juspay

Poem

A hop, a bop—Users returns to view,
Sidebar shines with a fresh, bright hue.
I twitch my nose; the toggle’s back,
No routes disturbed along the track.
Carrot cheers for uncommented calls—
Click, click, hooray, down UI halls! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title uses a clear conventional commit format, concisely describes the primary change of re-enabling the calling button in the calling feature, and avoids extraneous details or file lists, making it easy to understand the main intent at a glance.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/calling-feature-enable

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57292b8 and 4b9de69.

📒 Files selected for processing (1)
  • frontend/src/components/Sidebar.tsx (3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: MayankBansal2004
PR: xynehq/xyne#765
File: server/api/chat/chat.ts:5706-5712
Timestamp: 2025-09-04T08:53:33.995Z
Learning: MayankBansal2004 prefers to defer technical improvements like input validation and type safety when the current implementation is working, even when acknowledging potential benefits. He takes a pragmatic approach of "if it's not broken, don't fix it" and will revisit improvements when he has bandwidth.
Learnt from: MayankBansal2004
PR: xynehq/xyne#532
File: frontend/src/routes/_authenticated/chat.tsx:1238-1242
Timestamp: 2025-06-16T08:36:57.488Z
Learning: MayankBansal2004 prefers to keep working implementations even when security improvements are suggested, but appreciates being made aware of potential security considerations for future reference.
🔇 Additional comments (3)
frontend/src/components/Sidebar.tsx (3)

16-16: LGTM!

The Users icon import is correctly added and aligns with the re-enabled UI element below.


191-208: Implementation follows established patterns correctly.

The Users toggle button is implemented consistently with the History button above it, reusing existing state management and click-outside detection logic.


191-208: UsersModal already implements calling functionality. Verified that the component renders audio and video call buttons invoking initiateCall.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the 'Users & Calls' button in the sidebar by uncommenting the relevant code. My review focuses on improving the accessibility and correctness of the newly enabled button component. I've suggested a refactor to use a proper <button> element and correct the usage of the Tooltip component. This pattern could be applied to other similar buttons in this file for consistency and improved accessibility.

@shivamashtikar shivamashtikar merged commit 6514fbd into main Oct 10, 2025
3 of 4 checks passed
@shivamashtikar shivamashtikar deleted the fix/calling-feature-enable branch October 10, 2025 15:48
junaid-shirur pushed a commit that referenced this pull request Oct 13, 2025
## [3.13.6](v3.13.5...v3.13.6) (2025-10-10)

### Bug Fixes

* **calling-feature:** enabling calling button ([#1091](#1091)) ([6514fbd](6514fbd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants