-
Notifications
You must be signed in to change notification settings - Fork 56
Vespa fix env #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vespa fix env #1084
Conversation
…ners - Trim config-server heap from 4 GB to 2 GB and config-proxy from 2 GB to 1 GB to free memory for search nodes - Reduce main query container heap from 8 GB to 4 GB with tighter GC pause settings for smoother query handling - Dramatically increase content node heap from 10/14 GB to 20/40 GB and search node heap from 4/6 GB to 80/140 GB to accommodate 102 GB dataset and heavy embeddings/indexes - Add MaxGCPauseMillis flags and heap‑dump paths for larger nodes - Keep support components lightweight to maintain overall resource efficiency
Summary of ChangesHello @shivamashtikar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on optimizing memory allocation for Vespa components to prevent OOM errors and improve stability, particularly for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adjusts the JVM memory settings for various Vespa services to address OutOfMemory errors, primarily by significantly increasing the heap size for the searchnode. The changes are well-described and seem to correctly address the performance issues. My review includes a couple of suggestions to improve configuration clarity and ensure consistent debugging capabilities across all services.
Description
Key Changes:
Searchnode (Most Critical):
Content Node:
Query Container:
Config Server:
Added GC Tuning:
Memory Allocation Summary:
Testing
Additional Notes