Skip to content

Conversation

Ravishekhar7870
Copy link
Contributor

@Ravishekhar7870 Ravishekhar7870 commented Oct 8, 2025

Description

removed file Upload ui from the connectors

Testing

tested locally

Summary by CodeRabbit

  • New Features

    • Added an API Keys section in Integrations with a dedicated, always-visible sidebar item.
  • Refactor

    • Removed the File Upload integration and its associated integration page and navigation.
    • Integrations sidebar no longer hides items behind agent mode.
  • Behavior Change

    • Integrations now default to the Google integrations view when opened.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Ravishekhar7870, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR removes the file upload UI and all related frontend code and routing from the application's connectors section, as per issue XYNE-89. The changes include removing the UI element from the integrations sidebar, deleting the dedicated file upload component, and updating the route configuration to reflect its removal.

Highlights

  • Intent: This pull request aims to remove the file upload UI and its associated routing from the connectors section of the application, addressing issue XYNE-89.
  • Key Changes: - frontend/src/components/IntegrationsSidebar.tsx: The 'File Upload' list item and its corresponding Upload icon import have been removed from the integrations sidebar, ensuring it no longer appears in the UI.
  • frontend/src/routeTree.gen.ts: All references to the /integrations/fileupload route, including its import, route definition, and various type declarations, have been removed. This file is typically auto-generated, indicating the removal of the file upload feature from the application's routing.
  • frontend/src/routes/_authenticated/integrations/fileupload.tsx: The entire fileupload.tsx component file, which previously handled the file upload integration logic and UI, has been deleted.
  • Reviewer Activity: No specific reviewer activity has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Removes the File Upload integration and its generated route metadata, deletes the file-upload route/component, updates integrations index redirect to /integrations/google, and replaces the sidebar’s conditional “File Upload” item with an always-visible “API Keys” item linking to /integrations/apiKey.

Changes

Cohort / File(s) Summary
Sidebar navigation update
frontend/src/components/IntegrationsSidebar.tsx
Removed Upload import and the conditional “File Upload” list item; added always-visible “API Keys” item using Key icon pointing to /integrations/apiKey.
Route tree removal
frontend/src/routeTree.gen.ts
Deleted the generated route tree file: all imports, route definitions, route-type mappings, ROUTE_MANIFEST entries, and exports for routes (including integrations/fileupload and related route types).
File Upload route removal
frontend/src/routes/_authenticated/integrations/fileupload.tsx
Deleted the File Upload route/component and its types, state, handlers, UI composition (Sidebar, DataSourceSidebar, FileUpload, FileAccordion), and exports.
Integrations index redirect
frontend/src/routes/_authenticated/integrations/index.tsx
Changed mount-time navigation to redirect to /integrations/google instead of /integrations/fileupload.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Sidebar as IntegrationsSidebar
  participant Router

  Note over User,Router: New flow (after change)
  User->>Sidebar: Click "API Keys"
  Sidebar->>Router: navigate("/integrations/apiKey")
  Router-->>User: Render API Keys page
Loading
sequenceDiagram
  autonumber
  actor User
  participant Sidebar as IntegrationsSidebar
  participant Router

  Note over User,Router: Old flow (before change)
  User->>Sidebar: Click "File Upload"
  Sidebar->>Router: navigate("/integrations/fileupload")
  Router-->>User: Render File Upload page
  Note over Router: Route/component now removed
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • Remove Vespa API key setup #779 — Changes API Keys integration and touches routing for the API key surface (strong overlap with replacing File Upload with API Keys).
  • Fix/kb #727 — Adds/updates file-upload and knowledge-management components and the generated route tree (overlaps on removed fileupload artifacts).
  • feat(dashboard): usage analysis #681 — Modifies routeTree.gen.ts entries (related to removal of the generated route file).

Suggested reviewers

  • zereraz
  • shivamashtikar
  • kalpadhwaryu
  • junaid-shirur
  • devesh-juspay

Poem

I hopped through code and trimmed a trail,
Removed a burrow, swapped a key for mail.
Sidebar lighter, routes swept clean,
A tidy hop on the integration green. 🐇🔑

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title concisely reflects the primary change of removing the file upload UI from connectors and aligns directly with the bulk of the modifications in the PR. It includes the ticket identifier and a standard "fix" prefix, making the intention clear and consistent with the repository’s naming conventions. This ensures that reviewers and future readers immediately understand the main purpose of the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/fileUpload-remove

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4b4256 and b9b5013.

📒 Files selected for processing (1)
  • frontend/src/routeTree.gen.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • frontend/src/routeTree.gen.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the file upload UI from the connectors section, which is a straightforward change involving the deletion of a route and its associated UI components. The changes are consistent and achieve the stated goal. I've identified a couple of minor stylistic issues that should be addressed to maintain code quality and consistency. Since no specific style guide was provided, my suggestions are based on widely adopted formatting standards, such as those enforced by Prettier.

@Ravishekhar7870 Ravishekhar7870 deleted the fix/fileUpload-remove branch October 14, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant