Implement copy-and-delete fallback for atomicMove #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a fallback mechanism for `atomicMove` in `FileCodec.kt`. If `atomicMove` is unsupported (e.g., on Android 7 and below), it now attempts to copy the temporary file to the destination and then deletes the temporary file. Error handling is included to ensure the temporary file is cleaned up in case of a copy failure.
|
Thanks for the fix - the maintainer needs to approve this merge, correct? |
Author
Yes, that is correct |
Owner
|
Hi! Thanks for the PR. Is there a way to branch off to the unsupported mode for unit testing purpose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
This change introduces a fallback mechanism for
atomicMoveinFileCodec.kt. IfatomicMoveis unsupported (e.g., on Android 7 and below), it now attempts to copy the temporary file to the destination and then deletes the temporary file. Error handling is included to ensure the temporary file is cleaned up in case of a copy failure.I don't know if this is the best solution. Comments welcome.