[Issue-85] Reuse KStore instance if the same codec is provided #154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#85
When you create multiple stores pointing to the same file, those stores will not know about the updates from each other and can cause stores to be out of sync.I am thinking that we can use Factory pattern here.
When creating the instances of KStore, we check first if any instance exists for the provided codec. If yes, we can use the existing instance, otherwise we create a new instance and store it in a map.