Artifact for unit tests #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxfast
reviewed
Mar 15, 2025
Owner
xxfast
left a comment
xxfast
left a comment
There was a problem hiding this comment.
Hi! Thank you so much for the PR
Do you think we can name this module kstore-test instead of kstore-testing?
Author
|
Done ! |
Owner
|
Hi. Thank you for the PR! I've commented on #140 Could you clarify what prevents us from using the actual kstore-file in unit test environment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are removed as they seem unnecessary. Do we need to support the usage of key?
closes #140