XWIKI-22492: Livedata filter options are misread

[Sereza7]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22492

A regression on a11y tests has been reported caused by the commit for this ticket. E.g.
https://ci.xwiki.org/job/XWiki%20Environment%20Tests/job/xwiki-platform/job/master/786/testReport/org.xwiki.release.test.ui/AllIT/MySQL_9_1__Tomcat_11_jdk21__Chrome___Docker_tests_for_xwiki_platform_release___Build_for_MySQL_9_1__Tomcat_11_jdk21__Chrome___Docker_tests_for_xwiki_platform_release______/

Changes

Description

• Removed the problematic semantics from the selectize options.

Clarifications

• We cannot keep the aria-selected attribute on regular elements.
• The other solution would be to set the role of parents of these options elements. However:
  • There is two places where those elements are used: in the dropdown and in the input display. The listbox role would fit for the dropdown but not for the input.
  • As far as I can see, those elements are generated by selectize and "internal". If we want to change them we'll have to rely on some javascript that "patches" the default selectize (on the opposite to what is done with the options where selectize supports us providing our own template).
• While testing, I saw that these option roles and aria-selected did not add anything to a basic screen reader experience. They are not necessary to resolve the problem of options being misread. In XWIKI-22492: Livedata filter options are misread #3700 I added this as a side improvement, but we can easily remove it because it fails tests.

Screenshots & Video

None, the screen reader experience is the same as the one that was found in #3700 :
https://github.com/user-attachments/assets/5927a1bf-6232-4a54-a46c-e4a40f60f388

Executed Tests

Manual test with two screen readers to check that the changes reverted didn't revert the resolution from the initial commit. Everything is read out properly on Orca and NDVA.

Built the changes successfully with mvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war -Pquality. After that, I checked one test suite that failed because of the changes in the initial commits:
mvn clean install -f xwiki-platform-core/xwiki-platform-release/xwiki-platform-release-test/xwiki-platform-release-test-docker -Dxwiki.test.ui.wcag=true. The only WCAG violations found were warnings (not test fails) about labels, unrelated to this ticket.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • 16.10.X, same as XWIKI-22492: Livedata filter options are misread #3700