XWIKI-22496: Link dialog option button is not keyboard operable #3714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the HTML of the button * Added this button in the focusList * Removed weird listeners that would come with this focusList
mflorea
reviewed
Dec 9, 2024
...xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-link/plugin.js
Show resolved
Hide resolved
mflorea
approved these changes
Dec 18, 2024
mflorea
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Updated the HTML of the button * Added this button in the focusList * Removed weird listeners that would come with this focusList (cherry picked from commit a25f2b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22496
Changes
Description
Screenshots & Video
2024-12-05.12-44-14.mp4
Note that there's still issues with the pagepicker mode dropdown, but this PR's goal is not to fix this.
Executed Tests
Successfully built
mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins ;mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-webjar/and tested manually these changes on a live instance (see video above)Expected merging strategy