update surfdisp96 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add verbose_level to example 03
add version number
add `keyname` option for model rotation
enhance precision for writing src_rec_file
There was a problem hiding this comment.
Pull Request Overview
This PR updates the surfdisp96 surface wave dispersion calculation with improved error handling and adaptive step sizing, and modernizes the CI configuration to use conda.
Key changes:
- Enhanced surfdisp96 with adaptive step size selection based on minimum velocity values and proper error handling
- Added MPI rank-aware logging to reduce redundant output in parallel execution
- Updated CI configuration from apt-based dependencies to conda environment management
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/surfker/surfdisp96.f | Implements adaptive step size selection and adds error handling with program termination |
| src/tomo.f90 | Adds MPI rank checks to prevent duplicate logging messages in parallel execution |
| .github/workflows/build.yml | Replaces apt package installation with conda environment setup for better dependency management |
| examples/**/input_params.yml | Updates comments to clarify coordinate units (longitude/latitude in degrees, depth in km) |
xumi1993
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update surfdisp96:
Update CI:
Using conda to configure enviroment