Skip to content

Conversation

@da-liii
Copy link
Member

@da-liii da-liii commented Oct 28, 2025

Solve #8506

How to verify

Build the following minimal Qt project on Linux arm64
https://github.com/da-liii/xmake-qt-hello

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @da-liii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the Linux ARM64 architecture across the qt6base and qt6lib packages. By extending the on_install configurations, these essential Qt6 components can now be properly installed and utilized on ARM-based Linux environments, broadening the compatibility of the Qt6 framework.

Highlights

  • Linux ARM64 Support: Added linux|arm64 as a supported platform for the qt6base and qt6lib packages, enabling their installation and usage on ARM64 Linux systems.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for linux|arm64 to the qt6base and qt6lib packages. The changes are correct and achieve the intended goal. I have provided a couple of suggestions to improve the syntax for defining supported platforms, making it more concise and consistent with existing patterns in the codebase.

add_versions("6.9.1", "dummy")

on_install("windows|x64,linux|x86_64,macosx,mingw|x86_64@windows,linux,macosx", function (package)
on_install("windows|x64,linux|x86_64,linux|arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and consistency with how other platforms are defined in this file (e.g., android), you can group the architectures for the linux platform.

    on_install("windows|x64,linux|x86_64,arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group这个操作,可读性比较差。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

比如,单纯通过逗号做 string-split 会出问题

end)

on_install("windows|x64,linux|x86_64,macosx,mingw|x86_64@windows,linux,macosx", function (package)
on_install("windows|x64,linux|x86_64,linux|arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and consistency with how other platforms are defined in this file (e.g., android), you can group the architectures for the linux platform.

    on_install("windows|x64,linux|x86_64,arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package)

@SirLynix SirLynix merged commit a0e692d into dev Oct 28, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants