-
-
Notifications
You must be signed in to change notification settings - Fork 488
qt6: support linux arm64 #8507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt6: support linux arm64 #8507
Conversation
Summary of ChangesHello @da-liii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the Linux ARM64 architecture across the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for linux|arm64 to the qt6base and qt6lib packages. The changes are correct and achieve the intended goal. I have provided a couple of suggestions to improve the syntax for defining supported platforms, making it more concise and consistent with existing patterns in the codebase.
| add_versions("6.9.1", "dummy") | ||
|
|
||
| on_install("windows|x64,linux|x86_64,macosx,mingw|x86_64@windows,linux,macosx", function (package) | ||
| on_install("windows|x64,linux|x86_64,linux|arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
group这个操作,可读性比较差。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
比如,单纯通过逗号做 string-split 会出问题
| end) | ||
|
|
||
| on_install("windows|x64,linux|x86_64,macosx,mingw|x86_64@windows,linux,macosx", function (package) | ||
| on_install("windows|x64,linux|x86_64,linux|arm64,macosx,mingw|x86_64@windows,linux,macosx", function (package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solve #8506
How to verify
Build the following minimal Qt project on Linux arm64
https://github.com/da-liii/xmake-qt-hello