-
-
Notifications
You must be signed in to change notification settings - Fork 488
Auto-update simdjson to v4.0.7 #8488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine, automated update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the simdjson package to version v4.0.7. The change correctly adds the new version and its checksum to the package definition file. While the change is correct, I have added one comment regarding the growing list of versions to improve long-term maintainability of the package file.
|
|
||
| add_urls("https://github.com/simdjson/simdjson/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/simdjson/simdjson.git") | ||
| add_versions("v4.0.7", "d2d15490605858d3dd42e90d25e0fde31c53446b7d3cde9ef334449236927916") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding the new version is correct, the list of add_versions calls is becoming quite long, currently containing over 20 versions. To improve the long-term maintainability of this file, I suggest establishing a policy to periodically remove very old and likely unused versions. For example, you could consider removing versions older than a few major releases (e.g., v0.x, v1.x, v2.x) now that v4.x is available.
New version of simdjson detected (package version: v4.0.6, last github version: v4.0.7)